feat(review): label panel seats by roster name in the progress panel - #122
Merged
Merged
Conversation
Panelists appeared in the Workflow progress panel as panel-0/1/2. Surface the Titans roster name each seat already carries (Cronus, Rhea, Oceanus, ...) so the panel reads panel-Cronus etc. instead. Extract a hoisted panelSeatName(i) helper shared by the prompt prefix and the dispatch label; the name stays content-neutral (seat differentiation only, never steering what a seat reviews). Update the panel-agent test stubs to map the roster-name label back to the seat index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that panel is the default (and soon only) orchestration mode for the code-review engine, its panelists are the agents users see running in the Workflow progress panel at the bottom of the GUI. Until now they showed as the anonymous
panel-0,panel-1,panel-2. Each seat already carries a Titans roster name internally (used to keep panelist prompts byte-distinct so Bedrock draws independent votes); this PR simply surfaces that name in the progress label so the panel readspanel-Cronus,panel-Rhea,panel-Oceanus, … instead.Changes
review-core.mjs— extract a hoistedpanelSeatName(i)helper (roster: Cronus, Rhea, Oceanus, Hyperion, Themis; falls back toSeat Nbeyond the roster). It is shared by the existing prompt-prefix and the new dispatch labelpanel-${panelSeatName(i)}. The name remains content-neutral by design — it differentiates seats only and must never steer what a seat reviews (that would bias the panel).tests/lib/test_panel_review.shandtests/ab/lib/render_pr_mockup.mjs— the panel-agent stubs previously keyed panelists by parsing the integer out ofpanel-N. Updated them to map the roster-name label back to the seat index so the fixtures still align.Test plan
bash tests/run.sh— 846 passed, 1 skipped (clean tree)panel-Cronusetc.