feat: open module configuration from the store install bar - #943
Open
xihale wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The store detail page's install bar shows "Reinstall" when a module is installed and current — but at that point the reader usually wants to configure the module they just installed, not install it again.
Replace that resting button with "Manage", which opens the module's configuration screen (the same
Scopescreen the module list opens). It appears only when the module is installed, current, and the host has read its user id — so first installs and updates still get the install button, and LSPatch (no install host) is unaffected.The installed copy's user id is plumbed through
StoreInstallHost→RepoDetailsViewModel→RepoDetailsScreen, derived fromappInfo.uid / PER_USER_RANGEthe same way the module list and package broadcasts already do.Also drops the now-unused
store_reinstallstring across all locales.