Skip to content

Fix Timezone Handling in Commit Timestamps for Consistent Time-of-Day Metrics #8994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nishtha-agarwal-211 wants to merge 1 commit into from
Closed

Fix Timezone Handling in Commit Timestamps for Consistent Time-of-Day Metrics #8994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions utils/dateHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,13 @@ export function processCommitTimestamps(commitDates?: (string | Date)[] | null):
return metrics;
}

commitDates.forEach((dateString) => {
if (!dateString) return;
const date = new Date(dateString);
commitDates.forEach((dateItem) => {
if (!dateItem) return;
const date = new Date(dateItem);
if (isNaN(date.getTime())) return;

// Use getUTCHours() instead of getHours() to ensure timezone-agnostic
// results — getHours() returns local time which causes test failures
// in non-UTC timezones like IST (UTC+5:30).
const hour = date.getUTCHours();
const hour =
typeof dateItem === 'string' ? getAuthorLocalHour(dateItem) : dateItem.getUTCHours();

if (hour >= 6 && hour < 12) {
metrics.morning++;
Expand Down
Loading