Feature: Custom Color Palette Picker for SVGs - #8469
Conversation
Fixes JhaSourav07#6096 by preserving valid UTF-8, avoiding faulty binary text fallbacks, and adding heuristic to repair misencoded artifacts.
…owing them Moves buffer header checks outside try/catch blocks so that failures in buffer.toString (e.g. in tests mocking the method) correctly propagate to callers. Only third-party parser failures (pdf-parse, mammoth) are silently caught. Fixes the failing error-resilience test.
…bage-chars # Conflicts: # components/burnout/BurnoutRiskTable.tsx
…, and achievements types
…files to origin/main
…ypes to match origin/main
|
@pisum-sativum is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request adds a significant feature by allowing users to pick custom colors for SVG elements, which aligns with our previous decisions to enhance user experience through customization. For instance, the implementation of visually themed fallback SVGs for API errors and the addition of a dark/light preview background toggle both aimed to improve the visual appeal and usability of our components. This new feature will further empower users to personalize their SVGs. Thank you for your contribution, and I look forward to your updates! |
retenta-bot
Bot
changed the title
|
@Aamod007 @JhaSourav07 I have made the necessary changes. Kindly check and merge with appropriate labels. |
github-actions
Bot
added
the
status:blocked
|
🚨 Hey @pisum-sativum, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod007
added
level:intermediate
Aamod007
left a comment
Aamod007
left a comment
There was a problem hiding this comment.
A custom color palette picker is going to be super popular for the SVGs! Unfortunately, the CI pipeline is failing (\Format · Lint · Typecheck · Test). Please resolve the typecheck or linting errors so we can merge this!
|
Hi! Could you please re-run the CI pipeline to see if the recent failures resolve? Let us know if you need any help fixing the build errors! |
@Aamod007 I still can't solve the CI issue ;( Kindly check and merge if possible or if any change is needed let me know . |
|
@Aamod007 @JhaSourav07 Pls check and merge. |
|
@Aamod007 Any updates? |
Aamod007
added
level:advanced
Aamod007
left a comment
Aamod007
left a comment
There was a problem hiding this comment.
Great feature! Adding a custom color palette picker gives users way more flexibility to match their personal branding or website themes, rather than relying solely on the built-in presets. The UI implementation looks clean and propagates well to the generator outputs. Approved!
|
@Aamod007 There is a merge conflict do i need to resolve it? |
…ette-picker # Conflicts: # lib/validations.ts
|
@Aamod007 @JhaSourav07 I have resolved the merge conflict pls check and merge asap |
|
@Aamod007 @JhaSourav07 pls merge this pr asap |
|
@JhaSourav07 could you please merge all the PRs I've worked on? I've been requesting this for several days now but they are still pending. I would really appreciate it if you could review and merge them as soon as possible. Thank you! |
|
@JhaSourav07 Any update? |
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
3 similar comments
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
Description
Fixes #7807
Added a new
ThemeSectionUI component to the README generator that allows users to pick custom hex codes for the background (bg), text (text), borders (border), and icons (accent) of the generated SVGs.The generator state and SVG URL builders were updated to pass these custom parameters across all relevant SVG components (Streak, Repo Spotlight, Articles), breaking the restriction of relying solely on preset themes.
Pillar
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.