Repository navigation
Conversation
ghosthack
force-pushed
the
upstream-pr/cursor-paint-race
branch
from
October 10, 2026 21:17
6839eb9 to
98b42bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cursor move during painting can blank an existing character while the terminal buffer retains the correct text. For example, after typing
blah blah, moving the cursor from the blank after the phrase to the firstabetween cursor sampling and drawing paints the previously sampled blank over that letter.Pass the sampled cursor coordinates into
drawCursoralongside its character and style so the cursor is painted at the cell it was sampled from. Add an offscreen regression that deterministically interleaves a cursor move from another thread and checks that the firstastill has glyph pixels.Validation: the full
:ui:testsuite passes against upstream master. The regression fails with the previous implementation, including the published jediterm-ui 3.74 artifact, and passes with this fix. No live terminal sessions were used.