Repository navigation
Migrate CodeViewer sample to Kotlin Toolchain - #5743
Merged
Merged
Conversation
Since it is not possible to override Compose and Kotlin versions via the command line, copy them to a temporary directory and modify configuration in place
Victor Kropp (kropp)
requested review from
Vlad Konstantinov (Kpotko) and
Oleksandr Karpovich (eymar)
October 7, 2026 08:20
Oleksandr Karpovich (eymar)
approved these changes
Oct 7, 2026
Oleksandr Karpovich (eymar)
left a comment
Oleksandr Karpovich (eymar)
left a comment
Member
There was a problem hiding this comment.
Thank you for adding k/wasm target here!
Igor Demin (igordmn)
self-requested a review
October 7, 2026 19:47
Contributor
|
Checked desktop/web/Android on Windows, desktop/web/Android/iOS on macOs. Created: |
Igor Demin (igordmn)
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle is replaced with Kotlin Toolchain.
All validateExamples.sh scripts updated accordingly
Fixes CMP-10880 Migrate one of the samples to Kotlin Toolchain
Testing
Tested manually and via validateExamples.sh scripts with default and overridden versions.
Release Notes
N/A