Skip to content

Add Semantic Versioning starting Version 1.0.1.dev#519

Open
MathewBensonCode wants to merge 1 commit into
JeanPhilippeKernel:developfrom
MathewBensonCode:semantic-versioning
Open

Add Semantic Versioning starting Version 1.0.1.dev#519
MathewBensonCode wants to merge 1 commit into
JeanPhilippeKernel:developfrom
MathewBensonCode:semantic-versioning

Conversation

@MathewBensonCode

Copy link
Copy Markdown
Contributor
  • Bump patch version
  • Introduce Semantic Versioning

Should close #518

@MathewBensonCode MathewBensonCode force-pushed the semantic-versioning branch 2 times, most recently from fdc859b to 731c51d Compare April 7, 2026 17:51
@MathewBensonCode MathewBensonCode marked this pull request as draft April 7, 2026 17:57
- Bump minor version
- Introduce Semantic Versioning
@MathewBensonCode

Copy link
Copy Markdown
Contributor Author

Observations

  • The CMake Project command only accepts integers for the versions. Hence the use of 1.0.1.0 in the project command.
  • It appears that the tagging of the Version commits will have to be done on the branches by those with write access as I don't think tag information carries over via pull-requests.
  • Therefore creating the Version Change Commits and tags would be the responsibility of the maintainers as would the process of determining the level of change required.

Comment thread Obelisk/CMakeLists.txt
cmake_minimum_required (VERSION 3.17)

project (Obelisk
VERSION 1.0

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the discussion happening here #518, I think it should be 0.2.0

@JeanPhilippeKernel

Copy link
Copy Markdown
Owner

Hey @MathewBensonCode
are you still committed to complete this effort ? it's okay if you can't anymore, I'll need to reassign/re-prioritize it

@MathewBensonCode

Copy link
Copy Markdown
Contributor Author

hi @JeanPhilippeKernel, I have not had much time to put into it. I was working on figuring out which approach would work out for all platforms which turns out to not be very trivial.

To not hold you back you can re-assign it for now.

I have been working on something to solve the cross platform issues but will reveal it when I have got it working.

I apologise for the inconvinience.

@JeanPhilippeKernel

Copy link
Copy Markdown
Owner

no problem @MathewBensonCode, Will reassign this one then!
we're looking forward to reviewing your next PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Setup Versioning and tag

2 participants