Repository navigation
Conversation
Windows stabilization had moved service host ownership into the frontend, which fixed the child-webview path but split lifecycle and compatibility logic across TypeScript and Rust. This change pulls Windows host creation, tray/close visibility sync, popup handling, and restore behavior back into Rust while keeping the frontend as a thin command client. Constraint: Windows host lifecycle must avoid frontend-managed WebviewWindow creation while preserving OAuth and compatibility behavior Rejected: Keep the frontend dock manager and patch parity gaps | control-plane split caused restore and refresh regressions Confidence: high Scope-risk: moderate Reversibility: messy Directive: Do not reintroduce frontend-owned Windows service hosts unless tray/restore/OAuth parity is re-verified on real Windows machines Tested: pnpm exec vitest run (57 tests), pnpm exec tsc --noEmit, pnpm build, cargo test --manifest-path src-tauri/Cargo.toml, cargo build --manifest-path src-tauri/Cargo.toml, cargo fmt --manifest-path src-tauri/Cargo.toml --check, git diff --check Not-tested: Real Windows 10/11 smoke for tray hide/show, settings restore, focus restore, and OAuth popup flows
JS-banana
marked this pull request as ready for review
April 11, 2026 09:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR promotes the current
devbranch intomain.The branch already contains accumulated cleanup and product-scope changes on top of
main, and the latest work in this publish step completes the Windows Rust-first service-host recovery so Windows no longer depends on frontend-managed service windows.What Changed
devbranch cleanup and scope-reduction work already staged on the branch relative tomainWhy
The
devbranch is the current integration line for the Tauri-based AnyChat app. The latest blocker before publishing this branch was the Windows host split between TypeScript and Rust, which created lifecycle regressions around tray/restore and page-state retention. This PR publishes the branch after fixing that issue.Impact
devbranch state tomainRoot Cause
The recent Windows stabilization work moved service-window lifecycle into the frontend. That removed one failure mode but split host creation and compatibility behavior across two layers, which caused restore and refresh regressions. The fix was to move Windows host ownership back into Rust while keeping the frontend as a thin command client.
Validation
pnpm exec vitest runpnpm exec tsc --noEmitpnpm buildcargo test --manifest-path src-tauri/Cargo.tomlcargo build --manifest-path src-tauri/Cargo.tomlcargo fmt --manifest-path src-tauri/Cargo.toml --checkgit diff --checkRemaining Manual Checks