Repository navigation
Bump submodules: cFS-compliant F Prime command uplink and telemetry downlink - #4
devin-ai-integration[bot] wants to merge 5 commits into
Conversation
…mand packets Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
Original prompt from Devin Bot
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
… change) Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
…sts pass locally) Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
…nk path Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
Describe the contribution
Bumps the
libs/fprime_cfs,apps/fprime_gds, andapps/fprime_appsubmodule pointers so F Prime commands uplinked through the F Prime GDS traverse the cFS Software Bus as valid cFS command packets.Packet on the SB changes from:
to:
Component PRs (upstream):
wrapFprimeCommandsimplementation + 6 unit tests + SDD): CfsBridge: optional wrapping of F Prime command packets as valid cFS command packets fprime-community/fprime_cfs#14subscribeCfs(..., COMMAND)): FPrimeDeployment: subscribe to F Prime commands as cFS command packets fprime-community/fprime_app#9Note: the submodule pointers currently reference the PR fork branches so the end-to-end demo builds; they must be re-bumped to upstream
develcommits after the three upstream PRs merge.Telemetry/downlink framing is unchanged; the existing
CfsRouterstrips the 2-byte command secondary header using the deframer-providedhasSecHdrcontext.Testing performed
libs/fprime_cfsunit tests:fprime-util generate --ut && fprime-util build --ut && ctest— 100% passed (121 tests, including 6 wrap tests).make SIMULATION=native prep && make && make install(re-verified after rebasing fprime_app onto latest devel).core-cpu1and the F Prime GDS, sentcmdDisp.CMD_NO_OP; observedOpCodeDispatched,NoOpReceived,OpCodeCompletedin the GDS Events tab.Expected behavior changes
CfsBridge::configuregains an optionalwrapFprimeCommandsparameter (default false).System(s) tested on
Additional context
All three component PRs were reviewed by the F Prime multi-agent review with zero outstanding must-fix findings (CI safety Go, merge readiness Go).
Contributor Info - All information REQUIRED for consideration of pull request
Devin (Cognition AI) on behalf of Michael Starch, NASA JPL
Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c3026c19935746cd9eec36dce75afb8b
Update: cFS telemetry secondary header framing (downlink)
Submodules bumped again to make downlinked telemetry cFS-compliant. Telemetry on the SB changes from:
to:
fprime_cfs: newFPrimeCfs.CfsTlmFramer/FPrimeCfs.CfsTlmDeframercomponents andCfsTlmFramingsubtopology (Framing/Deframing), with SDDs and 13 new unit tests.fprime_app:CfsTlmFraming.Framinginserted betweenComCcsds.SpacePacketFramingand the cFS bridge on the downlink path.fprime_gds:CfsTlmFraming.Deframingstrips the secondary header before TM framing; downlink subscriptions now usesubscribeCfs(..., TELEMETRY)message IDs.Additional testing: all 131
libs/fprime_cfsunit tests pass; full native rebuild; all 5 local integration tests pass end-to-end through the GDS (commands, events, and telemetry through the new framing/deframing stages).