Repository navigation
ci: run External CI from the manifest.json of the revision under test; real conclusions for notify repos - #299
Open
devin-ai-integration[bot] wants to merge 5 commits into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
Prompt hidden (unlisted session) |
3 tasks done
…clusions for notify repos - head_manifest(): always read manifest.json from the F´ revision under test (PR head, merge-queue commit or manual fprime_ref) through this repository's contents API; the default branch's copy only serves the upstream_repository preflight and the baseline for `new` entries. `new` is only set when the PR itself edits manifest.json, so a stale branch does not resurrect a removed entry. Duplicate ids and a missing file fail early with a clear error. - check_conclusion()/finalize(): failure_policy no longer maps failures to `neutral` (GitHub folds neutral checks away in the merge box and the Checks sidebar); notify repos show the real conclusion and only keep the orchestrator job green. - dispatch hint also on 403 (observed when the repo was not yet in the App installation).
devin-ai-integration
Bot
force-pushed
the
devin/1794448189-ext-ci-manifest-selftest
branch
from
November 12, 2026 03:08
01c43d3 to
744cf36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/actions/ext-ci/README.md)Change Description
orchestrator.pyonly; the workflows are unchanged.manifest.json.head_manifest()reads it from the PR head, merge-queue commit or manualfprime_refthrough this repository's contents API (data only; the workflow and the script still come from the default branch, whose copy now only serves theupstream_repositorypreflight). A PR that adds or edits an entry therefore exercises it on its own checks. Entries the default branch does not have are markednewwhen the PR edits the manifest, andselect_repos()ignoreson_pr: falsefor them: the PR that introduces an entry is the one run it must get. Duplicate ids or a missing file fail early with a clear message.failure_policy: notify.check_conclusion()andfinalize()no longer map failures toneutral: GitHub folds neutral checks into the collapsed app group and out of the merge box, which read as "the check disappeared when it failed" on ci: add STM32H753XI-EVAL2 to supported platforms and external CI work… nasa/fprime#6378.notifynow only keeps the orchestrator job green; the check summary says the failure is informational.waiting): the check is retitled "Waiting for approval in " and both timeout clocks restart when it is released (hil.ymlruns its hosted job before the gated one, so the oldrun_started_atclock would have eaten the running allowance).dispatch failedon 403/404 hints at the External CI App installation (403 is what the stm32 repo returned before it was added).Rationale
Requested: a PR adding a manifest entry should run that entry and report it on its own checks, with the PR head's manifest used as is (reviewed like any
ci.yml), without checking out PR code in the privilegedworkflow_runjob.Testing/Review Recommendations
stm32-baremetal(on_pr: false,notify) dispatches both entries withfprime_repository=<fork>, waits throughwaiting, ends as afailurecheck and a green job; unchanged manifest keeps default behaviour (develon_pr: falseentry filtered); edited existing entry used as is; merge group and manualfprime_ref/pr_numberruns read the manifest of that revision; stale branch carrying an entry removed on devel does not getnew; duplicate ids / missing manifest raise before any Check Run; dispatch 403 → hint + failed check + exit 1; block failure/cancelled/timed_out mappings;paths_ignore-only PR → skipped checks; finalize after cancellation →cancelled, after a crash →failure; fork of F´ no-op; attempt 2 re-dispatches only non-green checks.gh api repos/nasa/fprime/contents/.github/actions/ext-ci/manifest.json?ref=<fork PR head sha>returns the fork PR's file for an open fork PR whose SHA is on no nasa/fprime branch, which is whathead_manifest()relies on.External CI / stm32-baremetalcheck should appear (cross-compile only:hil.ymlskips the board forfprime_repository != nasa/fprime).Future Work
Merge-queue runs dispatch every entry (
on_pronly applies to PR heads), so a hardware entry in a merge group would wait for the external repo's environment approval; nasa/fprime does not use the merge queue today.Contributor Checklist
AI Usage (see policy)
Code, documentation and the offline test scenarios were written by an AI agent under maintainer direction.
AGENTS.md).IAMAI
🟢 Devin Review found nothing to fix · View findings · Follow Devin's work