Repository navigation
fbuild: deduplicate enumerated build targets and sub-directories - #31
Closed
devin-ai-integration[bot] wants to merge 2 commits into
Closed
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
Original prompt from thomas.boyer.chammard
|
Closed
3 tasks done
Author
|
Closing: the duplicate metadata entries are fixed at the source in JPL-Devin/fprime#277, so this consumer-side dedupe is not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
MultiBuildTargetEnumeratorandRecursiveMultiBuildTargetEnumeratornow drop duplicate lines frombuild-targets.fprime-util/tests.fprime-util/sub-directories.fprime-util, keeping first-seen order (dict.fromkeys). Tests added with a duplicate-entry fixture.Rationale
Older fprime versions re-append the root directory's metadata on every CMake re-configure, so
fprime-util buildrunsninja all(and the<Deployment>_dictionaryinstall) once per duplicate. The root cause is fixed in fprime (JPL-Devin/fprime#277); this makesfprime-utiltolerant of build caches generated by frameworks without that fix.Testing/Review Recommendations
pytest test/fprime/fbuild/test_enumerators.py.Future Work
None.