Skip to content

Fix help text inaccuracies and remove dead code (WP3) - #19

Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin/wp2-exit-codesfrom
devin/wp3-help-text-hygiene
Closed

devin-ai-integration[bot] wants to merge 1 commit into
devin/wp2-exit-codesfrom
devin/wp3-help-text-hygiene

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Related Issue(s)
Has Unit Tests (y/n) n (help-text/hygiene only)
Documentation Included (y/n) n

Change Description

  • help_text.py: format help no longer claims backups are on by default (they are opt-in via --backup); documents --dirs/--exclude; new help documents --module, --rule-based-test, --phased, --from-source and drops "project" (project creation lives in fprime-bootstrap).
  • Hygiene: unused imports (re, glob, VersionException), placeholder-less f-strings, stale comments, builder: "Build" annotation under TYPE_CHECKING, dead parsed.settings = None.
  • build_helper.validate_tools_from_requirements: warning now prints the pre-filter candidate list (previously always []) and reports all per-candidate errors instead of only the last.
  • common/utils.py replace_contents: kept, with a deprecation note in the docstring.

Rationale

--help should not contradict actual behavior (WP3 of 9, stacked on #18). No signatures change.

Testing/Review Recommendations

Suite: 160 passed; pyflakes clean on touched files; black-25.1.0 clean.

Future Work

WP4–WP9 of the series.

Pushed by Devin AI

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/bba39c1277854bf8a1fd63a094f20e24
Requested by: @thomas-bc-autobot


Open in Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Author
Original prompt from thomas.boyer.chammard

I want this session to be a large effort to make fprime-tools more maintainable and cleaner code/less technical debt. Please make a plan to study that and deliver a master plan. Allocate subagent to find areas that can be improved, then more subagents to study it in detail and make a plan, then iterate on the plan with other review agents until the review agent and planner agent agree on an approved plan. Once the approved plan is done, have other implementer agents implement the plan, and review agents that build and test the result. Iterate until everyone agrees the code is correct and an improvement. Use subagents, high importance goals:

  • CLI and external APIs should ideally be left unchanged, or backwards compatibility layer left in
  • The less line of code changes, the easier the review. But if lots of LOC for high value simplification, it is ok.

Let’s go! Don’t stop, keep iterating until my goals are met.

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/wp3-help-text-hygiene branch from 7a84b74 to d7247b3 Compare August 28, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant