Repository navigation
Pin published wheel version to the release tag - #4
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…TEND_VERSION Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
Author
Original prompt from michael.d.starch
|
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets
SETUPTOOLS_SCM_PRETEND_VERSION: ${{ github.event.release.tag_name }}on theRun Builderstep of thebuild-wheelsjob innative-build.yml, so the publishedfprime-fppwheel version always matches the tag that triggered the release.Without this, setuptools_scm derives the version from
git describe, which resolves to the pre-existing tag when a new release tag is placed on a commit that already carries one (e.g. taggingv3.3.0a10on the same commit asv3.3.0a9, or a final release on the last alpha's commit). The workflow then rebuilds the old version and PyPI rejects the duplicate upload.On non-release events (push/PR runs of this reusable workflow)
github.event.release.tag_nameis empty, and setuptools_scm ignores an empty pretend version, so behavior is unchanged there. The leadingvin the tag is normalized away per PEP 440 (verified locally: building withSETUPTOOLS_SCM_PRETEND_VERSION=v9.9.9a3yields a9.9.9a3wheel).Same fix applied to fprime-tools (nasa/fprime-tools#343) and fprime-gds (nasa/fprime-gds#347).
Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/00563b4d0a4f4f08bcace3324aadf498