Skip to content

Pin published wheel version to the release tag - #4

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1787167307-release-tag-version
Open

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1787167307-release-tag-version

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Summary

Sets SETUPTOOLS_SCM_PRETEND_VERSION: ${{ github.event.release.tag_name }} on the Run Builder step of the build-wheels job in native-build.yml, so the published fprime-fpp wheel version always matches the tag that triggered the release.

Without this, setuptools_scm derives the version from git describe, which resolves to the pre-existing tag when a new release tag is placed on a commit that already carries one (e.g. tagging v3.3.0a10 on the same commit as v3.3.0a9, or a final release on the last alpha's commit). The workflow then rebuilds the old version and PyPI rejects the duplicate upload.

On non-release events (push/PR runs of this reusable workflow) github.event.release.tag_name is empty, and setuptools_scm ignores an empty pretend version, so behavior is unchanged there. The leading v in the tag is normalized away per PEP 440 (verified locally: building with SETUPTOOLS_SCM_PRETEND_VERSION=v9.9.9a3 yields a 9.9.9a3 wheel).

Same fix applied to fprime-tools (nasa/fprime-tools#343) and fprime-gds (nasa/fprime-gds#347).

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/00563b4d0a4f4f08bcace3324aadf498


Open in Devin Review

…TEND_VERSION

Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
@devin-ai-integration

Copy link
Copy Markdown
Author
Original prompt from michael.d.starch

In our nasa/fprime-tools, gds, bootstrap, fpp, etc releases, if I make no changes but try to do a new alpha release (e.g a2 -> a3, or a2 -> b1) with no changes. It trys to republish the original tag (e.g. a2) and then fails because that tag exists. How can I get it to operate on the newest tag and not infer the original tag attached to that hash

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants