Skip to content

Support include specifiers in the omit clause of telemetry packet sets - #3

Open
devin-ai-integration[bot] wants to merge 3 commits into
mainfrom
devin/1786655077-omit-include
Open

devin-ai-integration[bot] wants to merge 3 commits into
mainfrom
devin/1786655077-omit-include

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Summary

Fixes nasa#728: include "file.fppi" inside the omit { ... } clause of a telemetry packets set previously failed with } expected.

The omit clause now reuses the same member type and include-resolution path as normal packet members:

Ast.SpecTlmPacketSet(
  name: Ident,
  members: List[TlmPacketSetMember],
- omitted: List[AstNode[TlmChannelIdentifier]]
+ omitted: List[TlmPacketMember]  // channel identifier or include specifier
)
  • Parser.specTlmPacketSet parses the omit clause with tlmPacketMembers (same as packet bodies)
  • TopologyStateTransformer.specTlmPacketSetAnnotatedNode transforms omitted via tlmPacketMember, so ResolveSpecInclude recursively resolves includes there
  • TlmPacketSet.computeOmittedChannels collects TlmChannelIdentifier members (mirrors TlmPacket.fromSpecTlmPacket)
  • FppWriter/AstWriter/BasicUseAnalyzer/TlmPacketSetXmlWriter updated to the new member type
  • Spec doc updated: omit clause is now a telemetry-packet-member-sequence

Tests parallel the include path in normal packets:

  • fpp-syntax/test/syntax.fpp: include "omitted.fppi" in the omit clause (refs regenerated; fpp-format include/no_include refs follow)
  • fpp-check/test/tlm_packets/omit_include: full semantic check with includes in both a packet and the omit clause
  • fpp-to-json refs regenerated for the new omitted JSON shape

Also regenerates META-INF/native-image/reflect-config.json (install-trace + test, per compiler/README.adoc): the AST change renumbers the AstJsonEncoder/AnalysisJsonEncoder anonymous classes, and the stale entries broke fpp-to-json in the native-image build.

Rebased onto current main; full compiler test suite passes locally (compiler/test: All tests PASSED).

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/cc57d028fe1845cca9e128635e578ce1
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/cc57d028fe1845cca9e128635e578ce1?variant=devin


Open in Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Author
Original prompt from michael.d.starch

Want to try and fix this issue? nasa#728. Please do your best to follow the form, do not inject any unnecessary code, and add tests to parallel the include path in the normal packets.

Update the base JPL-Devin repository of fpp from nasa/fpp, and then make a PR there.

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

devin-ai-integration Bot and others added 2 commits September 10, 2026 20:32
Fixes nasa#728

Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/1786655077-omit-include branch from 403525c to d03618e Compare September 10, 2026 21:01
@devin-ai-integration

Copy link
Copy Markdown
Author

Closing in favor of the cross-fork PR to nasa/fpp.

Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support file inclusion in the omit section of a telemetry packet specifier

0 participants