Repository navigation
Support include specifiers in the omit clause of telemetry packet sets - #3
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
Author
Original prompt from michael.d.starch
|
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Fixes nasa#728 Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
devin-ai-integration
Bot
force-pushed
the
devin/1786655077-omit-include
branch
from
September 10, 2026 21:01
403525c to
d03618e
Compare
Author
|
Closing in favor of the cross-fork PR to nasa/fpp. |
Co-Authored-By: michael.d.starch <michael.d.starch@jpl.nasa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nasa#728:
include "file.fppi"inside theomit { ... }clause of atelemetry packetsset previously failed with} expected.The omit clause now reuses the same member type and include-resolution path as normal packet members:
Parser.specTlmPacketSetparses the omit clause withtlmPacketMembers(same as packet bodies)TopologyStateTransformer.specTlmPacketSetAnnotatedNodetransformsomittedviatlmPacketMember, soResolveSpecIncluderecursively resolves includes thereTlmPacketSet.computeOmittedChannelscollectsTlmChannelIdentifiermembers (mirrorsTlmPacket.fromSpecTlmPacket)FppWriter/AstWriter/BasicUseAnalyzer/TlmPacketSetXmlWriterupdated to the new member typeTests parallel the include path in normal packets:
fpp-syntax/test/syntax.fpp:include "omitted.fppi"in the omit clause (refs regenerated;fpp-formatinclude/no_include refs follow)fpp-check/test/tlm_packets/omit_include: full semantic check with includes in both a packet and the omit clausefpp-to-jsonrefs regenerated for the newomittedJSON shapeAlso regenerates
META-INF/native-image/reflect-config.json(install-trace+test, percompiler/README.adoc): the AST change renumbers theAstJsonEncoder/AnalysisJsonEncoderanonymous classes, and the stale entries brokefpp-to-jsonin the native-image build.Rebased onto current
main; full compiler test suite passes locally (compiler/test: All tests PASSED).Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/cc57d028fe1845cca9e128635e578ce1
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/cc57d028fe1845cca9e128635e578ce1?variant=devin