Skip to content

Promote all-XML well-formedness and PO validity to blocking CI #24

Closed

Description

@JMAN730

Part of #12
Blocked by: #23

Question

Once the cleanups from #23 land, extend the blocking tier of .github/workflows/ci.yml per the decision in Decide which kodi-addon-checker findings to fix and which checks to promote to blocking:

  • All-XML well-formedness: extend the existing addon.xml step to parse every .xml under the addon dirs (stdlib xml.etree).
  • PO validity: parse every strings.po with polib.
  • Document the permanently-accepted advisory noise (skin 1024×600 screenshots, repository <dir minversion/maxversion>, complex-entry-point warnings, .xbt endings) next to the advisory job so future readers know it is deliberate.

kodi-addon-checker itself stays advisory — never blocking.

Done when both new steps gate CI and a run on current main (post-#23) is green.

Activity

  1. self-assigned this
    on Jul 6, 2026
  2. JMAN730 commented on Jul 6, 2026

    @JMAN730
    OwnerAuthor

    Resolved. Implemented in PR #25 (commit bf6b2e6), stacked on the #23 cleanups so the fixes and the checks that gate them land atomically:

    • XML well-formedness step in .github/workflows/ci.yml now parses every .xml under each addon dir (159 files across 10 dirs) instead of only the ten addon.xml manifests.
    • New PO validity step parses every strings.po with polib (9 files).
    • The permanently-accepted advisory noise from the checker findings decision is documented in a comment block above the advisory job (skin 1024×600 screenshots, repository <dir minversion/maxversion>, complex-entry-point warnings, .xbt endings).
    • kodi-addon-checker itself remains advisory, exactly as decided.

    Done-criteria check: both new steps gate the blocking job and are green in real CI on the branch — Blocking checks ✓ (13s). The "green on current main" half of the criterion follows automatically when PR #25 merges, since these commits are what main will contain.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions