Skip to content

Apply the agreed checker cleanups across addon sources #23

Closed

Description

@JMAN730

Part of #12

Question

Execute the source cleanups agreed in Decide which kodi-addon-checker findings to fix and which checks to promote to blocking (full detail in its resolution comment):

  • Fix all syntax-level defects: plugin.program.theredwizard/resources/settings.xml, the 11 invalid skin XMLs, the 5 invalid skin .po files, redlight's empty <license/>, self-close the two service xbmc.service extensions, add lang attrs to mp3streams' summary/description.
  • Remove start="startup" from mp3streams' and gratisred's xbmc.service extensions.
  • Migrate mp3streams' resources/language/english/strings.xml → resources/language/resource.language.en_gb/strings.po (IDs unchanged).
  • Rescale chainsliveplayer's fanart to 1280×720.
  • Bump each touched addon's version so the repo picks up the changes.

Done when the advisory checker reports only the permanently-accepted noise (skin 1024×600 screenshots, repository <dir minversion/maxversion>, complex-entry-point warnings, .xbt endings) and CI is green.

Activity

  1. self-assigned this
    on Jul 6, 2026
  2. JMAN730 commented on Jul 6, 2026

    @JMAN730
    OwnerAuthor

    Resolved. All agreed cleanups applied in PR #25 (commit 783ee74, 27 files):

    • 11 malformed XMLs fixed (theredwizard settings.xml + 10 skin files): raw &/< escaped, glued attributes separated, and the mis-scoped comment in SettingsProfile.xml that swallowed an </item> repaired.
    • All 5 skin strings.po files parse under polib: inner quotes escaped, comment lines normalized — and two genuine data bugs surfaced and fixed in it_it (a lost msgstr for #40195 and a mangled msgstr for #31295). The bogus "en_gb not present" error is gone with them.
    • Service extensions self-closed; start="startup" removed from mp3streams + gratisred; lang attrs added to mp3streams metadata.
    • mp3streams language dir migrated: english/strings.xml → resource.language.en_gb/strings.po, 17 strings, IDs unchanged (code goes through getLocalizedString, settings labels reference the same IDs).
    • redlight license set to GPL-2.0-or-later (majority repo convention); chainsliveplayer fanart rescaled to 1280×720.
    • Versions bumped on all eight touched addons (mp3streams to 2026.07.07 — one line above PR Fix plugin.audio.mp3streams broken <assets> paths #22's 2026.07.06; the two PRs conflict trivially on that line, second-to-merge keeps 2026.07.07).

    Done-criteria check (local run, network checks stubbed): every .xml parses, every strings.po parses, py_compile clean, tools/build_repo.py clean. Advisory checker output is down to exactly the accepted noise from the checker findings decision — skin 1024×600 screenshots, repository <dir minversion/maxversion>, complex-entry-point warnings, .xbt endings — plus the mp3streams asset paths owned by the still-open PR #22.

    Python addons: 12 problems → 3 (2 are #22's, 1 is the accepted repository false positive). Skin: 26 problems → 10 (all accepted screenshots).

    This unblocks Promote all-XML well-formedness and PO validity to blocking CI once PR #25 merges.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions