Repository navigation
Decide which kodi-addon-checker findings to fix and which checks to promote to blocking #20
Description
Part of #12
Question
The advisory tier now has a measured baseline (see the CI prototype resolution on #16): 12 problems / 257 warnings across the Python addons (245 warnings = non-whitelisted file endings) plus 26 problems / 4 warnings from the skin. Which of these are worth fixing in the sources, and which checker categories should then graduate from advisory to blocking so regressions can't creep back in?
Candidate cleanups, roughly by effort: delete/ignore non-whitelisted junk files (bulk of all warnings); fix plugin.program.theredwizard/resources/settings.xml (reported invalid); migrate mp3streams' legacy english/strings.xml language dir to resources/language/resource.language.en_gb/strings.po; resize the wrong-sized fanart; decide whether the xbmc.service schema complaints (e.g. start="startup") are checker false-positives to ignore permanently.
Needs maintainer appetite — this is source cleanup across addons the contributor doesn't own decisions for.
Activity
JMAN730 commentedon Jul 6, 2026
Resolved via a grilling session, grounded in a fresh checker run (locally reproduced with the two network-dependent checks stubbed; findings match the CI baseline once sandbox proxy noise is excluded — the mp3streams icon/fanart errors belong to the still-unmerged PR #22 and are not part of this decision).
Fix in sources (agreed)
plugin.program.theredwizard/resources/settings.xml: missing space (visible="false"default="false") and raw&in a label16x9/Font.xml,includes.xml,IncludesMainButtons*.xml,SettingsProfile.xml,custom_skinsettings_1113.xml,Custom_DialogAppswitcher_1125.xml,fonts/backup_Font.xml): raw&in attributes and missing inter-attribute spaces.pofiles (en_gb, fr_fr, de_de, it_it, es_ar): unescaped double quotes / smart quote in msgids — fixing these also clears the bogus "default language en_gb not present" errorplugin.video.redlight: empty<license/>gets license textservice.apkredwizard+service.multiinstallmybinaries: self-close the<extension point="xbmc.service">elements (schema requires empty content)plugin.audio.mp3streams: addlangattributes to<summary>/<description>start="startup"from thexbmc.serviceextensions in mp3streams and gratisred — the attribute was removed in Kodi 19; services always start at login on every version this repo targets.resources/language/english/strings.xml→resources/language/resource.language.en_gb/strings.po(string IDs unchanged, sogetLocalizedStringkeeps working).Permanently-accepted advisory noise (agreed — document, never fix)
repository.redwizard<dir minversion/maxversion>: checker false positive — Kodi supports these attributes and the multi-channel repo depends on them..xbtnon-whitelisted-file-ending warnings: compiled textures are mandatory for skins.Promote to blocking (agreed)
Once the fixes land, two new standalone blocking CI steps (stdlib/polib — not the checker itself):
.xmlunder the addon dirs.strings.po.kodi-addon-checkerstays advisory permanently — it needs network access and has known false positives.Follow-up task tickets created on the map for the cleanup work and the CI promotion (the latter blocked by the former).
Generated by Claude Code
Fix checker-reported defects across addon sources
Promote all-XML well-formedness and PO validity to blocking CI
Fix checker-reported defects across addon sources
Promote all-XML well-formedness and PO validity to blocking CI
Fix checker defects, promote XML/PO checks to blocking CI; add agent …
docs: spec for audio language sort-to-top options (issue #20)
v1.9.6
v1.9.6 (release)