Repository navigation
docs(ops): standardize on default Docker context and add port-collision guard (#96) - #107
Merged
Merged
Conversation
…on guard (#96) Documents DOCKER_CONTEXT=default / docker context use default in README.md to prevent concurrent runs on Docker Desktop (desktop-linux) producing port-bind collisions and unattached containers. Adds scripts/check-ports.sh and Taskfile check-ports task to detect published port collisions before compose boot. Cleans up stale benchmark and profile containers. Adds unit test to test_benchmarks.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #96.
Standardizes deployment documentation and tooling on the system Docker daemon (
defaultcontext) and adds a port conflict check to prevent host-port bind collisions.Key Changes
docker context use default) to avoid running duplicates on Docker Desktop (desktop-linux).check-portstask in Taskfile.yml to detect if published stack ports (5080, 5081, 4317, 4318, 9000, 9090) are already bound before starting containers.oo-bench-*) and exited profile containers fromdocker ps -a. Verifieddesktop-linuxcontext and stale/home/john/lokidirectories are no longer present.test_check_ports_script_exists_and_executableto tests/test_benchmarks.py.Verification
bash scripts/check-ports.sh: Verified output and exit code.uv run pytest tests/test_benchmarks.py: 9 passed in 0.25s.uv run pytest tests/: 362 passed, 40 skipped across the full test suite.