Repository navigation
perf: add direct binary encoding for collection models - #20
Merged
Merged
Conversation
Encode supported collection models into a single byte buffer without building intermediate codec wrappers. Preserve the existing path for mixed records, custom codecs and unsupported inputs, including validation order and map sorting. Add coverage for binary parity, custom hooks, mutable schemas, empty collections and input isolation.
Encode supported collection models into a single byte buffer without building intermediate codec wrappers. Preserve the existing path for mixed records, custom codecs and unsupported inputs, including validation order and map sorting. Add coverage for binary parity, custom hooks, mutable schemas, empty collections and input isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encoding collection models builds intermediate codec wrappers before producing bytes. This PR adds a direct path that writes supported models into a single byte buffer.
Serializable.to_jam_bytes()for models whose top-level fields are arrays, vectors, bounded vectors or maps.to_codec_type()methods and runtime schema changes through compatibility checks and fallback.No Pyjamaz call-site changes are required; the optimization becomes available when the updated codec is installed.
Validation
Performance
Local median wall times from three alternating runs against the existing encoder:
End-to-end gains are modest and workload-dependent. Measurements showed noticeable run-to-run variation, so small differences should be treated cautiously.