fix(git): prevent diff stats polling process storms - #446
Merged
Conversation
Contributor
|
I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
git diff --shortstatrequests per worktree and reuse completed results for two secondsRoot cause
useQueries()can return a new result-array reference on each render. EnsoAI rebuiltworktreesMapfrom that array, andTreeSidebartreated the new map reference as a polling dependency change. Because the effect fetched immediately before starting its interval, ordinary rerenders repeatedly bypassed the intended 30-second cadence and spawned short-lived Git processes.Validation
pnpm test- 68/68 tests passedpnpm build- main, preload, and renderer production builds passedgit diff --check upstream/main...HEADpassedKnown repository baseline
pnpm typecheckstill reports the pre-existing errors atsrc/renderer/App.tsx:472andsrc/renderer/App.tsx:476; neither line is changed by this PRpnpm lintremains blocked by existing formatting/lint debt, while all files changed by this PR pass BiomeRisk
Diff statistics can be up to two seconds stale after a completed request. Error and empty results use the same short cache window to prevent retry storms. No production dependency or user-facing UI change is included.