Repository navigation
Conversation
AppsModel deferred row insertion for apps whose theme icons were not yet resolvable at startup, causing rows to be inserted one by one after the 3-second polling interval, producing a visible scroll/progressive loading effect. Fix: insert all accepted rows immediately. The waitForIcon() tracking mechanism is preserved (timer + pending queue), but shouldDelaySourceIndex() now always returns false. When a pending icon becomes ready, the pendingAppItemReady handler emits dataChanged(IconNameRole) on the existing row instead of inserting a new one. rebuildRows() no longer skips pending items since they are already in the model. This does not regress bug-347859/371833: apps still display immediately, icons briefly use a fallback and refresh in-place once resolved. Log: Fix progressive loading in windowed launcher by inserting all app rows immediately and updating icons in-place via dataChanged. PMS: BUG-372641 Influence: Windowed launcher now loads all apps at once without progressive scroll; icon fallback may flash briefly before refreshing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test