Repository navigation
Conversation
…sa#67) The Max Current field was capped at 32 A, so chargers supporting 40 A or more could not use their full range. The field now accepts up to 80 A, and every current setpoint is clamped to the number entity's own min/max attributes so a wider configuration never causes a rejected service call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Max Current field of dynamic-current appliances was capped at 32 A (
MAX_CURRENT), so chargers that support 40 A or more (e.g. a Tesla Wall Connector at 40 A / 240 V) could not use their full range.Change
MAX_CURRENT(the field limit only) raised to 80 A.min/maxattributes before writing (same approach already used for the battery discharge and max-charge entities). The optimizer therefore never commands more than the user's Max Current or the entity's native max, and a wider configuration cannot cause a rejectedset_valuecall. The clamped value is also used for the confirmation check, so it is not rewritten every cycle.Validation
tests/test_block3_coordinator.py: clamp to entity max (and no rewrite once confirmed), 40 A allowed when the entity permits it, Max Current field accepts 40 A.scripts/check_public_tree.py: 0 findings.Closes #67