Skip to content

Ignore cheap-window target current for non-dynamic appliances (#68) - #77

Open
MonsterD1 wants to merge 1 commit into
InventoCasa:mainfrom
MonsterD1:fix/68-cheap-target-current-non-dynamic
Open

MonsterD1 wants to merge 1 commit into
InventoCasa:mainfrom
MonsterD1:fix/68-cheap-target-current-non-dynamic

Conversation

@MonsterD1

Copy link
Copy Markdown

Problem

On the "Dynamic Current" step, an appliance without dynamic current could not proceed while the "Cheap-window target current" field held a value (pre-filled, or left over from an earlier dynamic configuration). The validator returned cheap_grid_target_current_requires_dynamic and the user had to clear the field manually.

Change

  • Add and reconfigure flows: when dynamic current is off, the cheap-window target current is dropped from the input instead of raising an error. The existing cleanup then removes any stored value, so no stale setting survives.
  • The now unused error string is removed from strings.json and translations/en.json.

Validation

  • The rejection test is replaced by two regressions (add flow with a stale stored value, reconfigure from dynamic to non-dynamic); the dynamic-current acceptance test is unchanged.
  • Full suite on HA 2025.8 / Python 3.13: 1290 passed. scripts/check_public_tree.py: 0 findings.

Closes #68

…oCasa#68)

The current step rejected a pre-filled cheap-window target current when
dynamic current was off, so the user had to clear the field manually.
The value is only meaningful for dynamic-current appliances; it is now
dropped silently in both the add and reconfigure flows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration blocks on default value

1 participant