Repository navigation
fix(wgpu): skip zero-area surfaces; render through D3D12 or GL on Windows - #2
Merged
Merged
Conversation
Configuring a surface or creating a texture with a zero dimension is a wgpu validation error, and wgpu's default handler panics on it inside baseview's frame/event callback, where a plug-in host aborts. Hosts can collapse an embedded view to 0x0. Measured with de-artifact on a Windows 10 VM: SetWindowPos(editor child, 0x0) -> 'Both Surface width and height must be non-zero' -> exit 0xC0000409 (AUD-2367).
wgpu enumerates Vulkan before D3D12 and keeps that order between adapters of the same type, so a normal Windows GPU rendered the editor through Vulkan and pulled every Vulkan implicit layer (overlays, capture and vendor layers) into the plug-in host's process. D3D12 drives the same GPUs and its WARP adapter covers machines with no GPU driver; GL remains for GPUs without a D3D12 driver. WGPU_BACKEND still overrides the default for diagnosis (de-artifact AUD-2367).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the two commits de-artifact already ships (
750ce16, tagpinned/de-artifact-aud2367) intomain, so every Intrect consumer sits on one tip before the fork moves into the intrect-plugin monorepo (framework/egui-baseview). The branch fast-forwards frommain; CI on the branch tip is green.