Repository navigation
Conversation
…ound retained CLI output (AGT-3423) - workCommand: SIGTERM aborts the pipelines like Ctrl-C, so the finally still uninstalls the handler and closes the coordinator; exits 143 (second signal force-quits) - adapters: stdout/stderr per CLI stage are kept as a bounded tail (32 MiB / 1 MiB) starting on a line boundary with a skip-safe marker, so result/cost/error events still parse
…-path output bound (AGT-3423)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇
AGT-3423의 6개 항목을 origin/main(3ef5b70)과 대조했습니다. 4개는 #789/#791에서 이미 들어갔고, 남은 2개를 이 PR에서 고칩니다.
outputRetention.tsBoundedOutput: stage당 stdout 32 MiB / stderr 1 MiB, 마지막 부분(결과·비용·에러 이벤트가 있는 곳)을 줄 경계에서 보존하고 JSON-line 파서가 건너뛰는 표시 줄을 앞에 붙임processRegistry.tsescalationTimers(#791)ciWorker.tstimeout: 30_000, maxBuffer(#789)fixCommand.tsmaxBuffer+timeout: 300_000(#789)finally(핸들러 해제,coordinator.close())보다 먼저 죽었음. 이제 SIGTERM도 같은 abort 경로를 타고 exit 143, 두 번째 신호는 강제 종료dev.tscancelTask는 abort만 하고 항목은 완료 핸들러에서 지움 (#791)왜
systemd·docker stop·CI 취소는 SIGTERM을 보냅니다. 이 경우 Ctrl-C와 달리 claim·coordinator 정리가 실행되지 않았습니다. CLI 출력은 실행 내내 문자열을 이어 붙이기만 해서, 폭주하는 stream이 있으면 daemon 메모리가 계속 늘었습니다.
검증
npx vitest run src/cli/workCommand src/adapters→ 63 files, 1044 tests 통과 (7 skipped는 기존 것)process.emit('SIGTERM')이 기본 wiring으로 run을 abort하고 143으로 끝남, SIGTERM이 pipeline signal을 abort하고 handler를 해제하며 143으로 끝남, 기본 wiring이 SIGTERM listener를 달았다가 떼어 냄,BoundedOutput상한·줄 경계·잘린 뒤에도extractStreamJsonError가 결과를 찾음·줄바꿈 없는 거대한 줄base.ts를 main 버전으로 되돌리면 이 테스트가 실패하는 것을 확인npm run typecheck통과주의