ci: preserve tool parity artifacts by path - #2417
Merged
Merged
Conversation
xsscx
requested review from
ChrisCoxArt,
colourbill-ctrl,
dwtza and
maxderhak
as code owners
September 5, 2026 14:59
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes directly fix the reported collision/coverage loss by switching intermediates/logs to path-derived keys and updating the consuming loops/scripts consistently.
Pull request overview
This PR addresses Issue #2275 by eliminating basename-based collisions in the Linux full-test “tool parity” sweeps, so XML intermediates and per-profile logs remain unique and round-trip coverage can’t silently drop profiles that share a filename.
Changes:
- Key
iccDumpProfileandiccToXmlper-profile outputs by path relative toTesting/(and create needed subdirectories) instead of flattening tobasename. - Add a guard that fails CI if the number of successfully converted profiles doesn’t match the number of XML outputs produced.
- Update
iccFromXmlround-trip and classification to traverse nested XML/log paths (and adjust manifest matching to remain basename-based).
File summaries
| File | Description |
|---|---|
| .github/workflows/_build-test-unix.yml | Makes tool-parity logs/intermediates path-unique, adds output-count mismatch detection, and preserves nested log paths when collecting artifacts. |
| .github/scripts/iccdev-classify-fromxml-logs.sh | Classifies nested fromxml logs recursively and maps them back to nested round-trip outputs while keeping expected-failure matching compatible with the existing manifest. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
#2275
Checklist
docs/build.mddocs/ctest.mdbase...HEADcontract matrix for cross-cutting changes:producer, consumer, build/runtime behavior, platform/toolchain boundary,
CI trigger, dependency owner, and local evidence
docs/python-packaging-release.mdfor PR and merge requirementsm_membersLegal Requirements
All official software projects hosted by the International Color Consortium (ICC)
follows the open source software best practice policies. The International Color Consortium IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).
Contributor License Agreements
Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA).
There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.
If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.
If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement
License
ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.
Copyright Notices
All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.
INTELLECTUAL PROPERTY & PATENTS
Participation in ICC's development activities is subject to ICC's Patent Policy.
Maintainer Review Required
If you have questions, contact a listed Maintainer.