CI: Add CTest for ApplySearch Threading - #2374
Conversation
PR Author Notes2026-09-03 18:10:29 UTC This PR started in #2363 but Stacked PR was not helping with the Copilot Code Review Process.
|
26268ca to
f01b651
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The new threads-debugcalc regression currently doesn’t assert the expected diagnostic (so it can pass for unrelated failures), and the threaded fixture generation uses a hard-coded repeat count that is unnecessarily fragile.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR strengthens CI regression coverage for iccApplySearch threading by expanding the existing iccdev.applysearch-cli-args CTest to validate deterministic output across multiple -threads settings and to pin several malformed thread-count argument cases.
Changes:
- Generate a >1024-row derived input fixture to ensure the threaded bulk path is exercised, then compare output across
-threads 0/1/2/4/8. - Add negative tests for invalid
-threadsvalues and invalid flag usage combinations (including-debugcalc+ non-1 threads). - Document the expanded
iccdev.applysearch-cli-argscoverage indocs/ctest.md.
File summaries
| File | Description |
|---|---|
docs/ctest.md |
Documents the expanded iccdev.applysearch-cli-args threading and argument-surface coverage. |
.github/scripts/iccdev-applysearch-cli-args-regression.sh |
Extends the regression script to exercise threaded batch apply, validate deterministic output across thread counts, and pin additional -threads rejection cases. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
colourbill-ctrl
left a comment
There was a problem hiding this comment.
Reviewed at f01b651d. CI skipped every build lane on this script+docs change, so the execution evidence is local: ctest -R iccdev.applysearch-cli-args passes against master 3e2224d2 in 1.8s.
The fixture is not vacuous: 1,040 rows clears the 1,024 bulk threshold, so pixelsPerThread drops to 128 and every requested worker dispatches. Measured on that exact fixture, -threads 1/2/4/8: 0.28s / 0.21s / 0.10s / 0.07s wall, CPU rising 0.28s to 0.52s, output byte-identical throughout. Rejection cases match the tool: bare -threads, -threads 8 alone, -1, 257 (with the expected 0..256 text), nope, and -debugcalc with workers all exit non-zero.
Approving.
Signed-off-by: David Hoyt <dhoyt@hoyt.net>
PR Summary
#2346
Checklist
docs/build.mddocs/ctest.mdbase...HEADcontract matrix for cross-cutting changes:producer, consumer, build/runtime behavior, platform/toolchain boundary,
CI trigger, dependency owner, and local evidence
docs/python-packaging-release.mdfor PR and merge requirementsm_membersLegal Requirements
All official software projects hosted by the International Color Consortium (ICC)
follows the open source software best practice policies. The International Color Consortium IP policy governs ICC specification development and contributions to ICC open source software. Software contributions are also covered by the Contributor License Agreement (CLA).
Contributor License Agreements
Developers who wish to contribute code to be considered for inclusion
in ICC software must first complete a Contributor License Agreement
(CLA).
There is no cost or membership requirement to sign the ICC Contributor License Agreement (CLA). Please note that this is different from membership in the International Color Consortium (ICC). If your organization relies on our projects, please become a member. Membership dues are an essential source of funding and investment for these projects.
If you are an individual writing the code on your own time and you are SURE you are the sole owner of any intellectual property you contribute, you can sign the CLA as an individual contributor.
If you are writing the code as part of your job, or if there is any possibility that your employer might think they own any intellectual property you create, then you should use the Corporate Contributor Licence Agreement
License
ICC software is licensed under the BSD 3-Clause "New" or "Revised" License. Contributions to ICC software projects should abide by that license unless otherwised specified or approved by the ICC.
Copyright Notices
All new source files must begin with the ICC Copyright notice and include or reference the BSD 3-Clause "New" or "Revised" License.
INTELLECTUAL PROPERTY & PATENTS
Participation in ICC's development activities is subject to ICC's Patent Policy.
Maintainer Review Required
If you have questions, contact a listed Maintainer.