Repository navigation
fix: strict pipes and AOT clippy hygiene - #75
Merged
gRoussac merged 1 commit intoSep 7, 2026
Merged
Conversation
Make builtin and demo pipes return real TypeMismatch errors, and fix generated for-loop emission so blanket needless_pass_by_value / redundant_clone allows are no longer needed. Co-authored-by: Cursor <cursoragent@cursor.com>
gRoussac
approved these changes
Sep 7, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EvalError::TypeMismatchon bad types/args; dropunnecessary_wrapsallows while keepingPipeFnasResult.needless_pass_by_value/redundant_cloneallows; fix for-loop emission (row/ item move intoArc) and avoid redundantget_value().clone().docs/SPEC.md(display still maps eval failure to empty via existingunwrap_or).Test plan
make lintmake demo-checkmake demo-buildmake testmake docmake audit && make deny