Skip to content

[3.x] Cannot use custom translators #137

Description

@mikerockett

I use a custom translator for Project Fluent, but this conflicts with the plugin:

InterNACHI\Modular\Plugins\TranslatorPlugin::__construct(): Argument #1 ($translator) must be of type Illuminate\Translation\Translator, Modules\Foundation\Translation\FluentTranslator given

Should TranslatorPlugin be updated to use the contract instead? Happy to open a PR, but only if it is the correct move (seems it would be).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions