Add etas to results table - #46
Merged
Merged
Conversation
dominic-irx
reviewed
Jun 5, 2026
dominic-irx
left a comment
Contributor
There was a problem hiding this comment.
works great if everything works smoothly.
can you write a test to make sure that if all fits fail that the function returns something useful (warning, maybe)? also looks like line 97 (par_dummy) won't have etas.
Collaborator
Author
Done! c366ba5 addresses the above. We actually had an appropriate warning already in |
dominic-irx
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds etas to the results table. I opted to add two types of etas:
eta<nn>etas, which are the iterative empirical Bayes estimates that pair withiter_ipred.map_eta<nn>etas, which are the full-data MAP empirical Bayes estimates that pair withmap_ipred. These are the equivalent of the etas reported in a NONMEM output table, and are what you'd use for an empirical eta-distribution plot.I also updated the documentation for
run_eval()to document its outputs more thoroughly, particularly with a@detailssection describing the results table.