[Abidoyesimze]

Summary

Part of #290. Works through the full checklist posted there — items 1 (packaged install) and 7 (README wording) are deliberately left for #282 and #280 respectively, so this PR doesn't close #290 on its own.

Blocks newcomers:

• setup.md: both install options (wheel download, GitHub dist/ subdirectory) were broken. Replaced with git clone + pip install -e . (the method CLAUDE.md already documents as working) and added a note that a packaged-release install is tracked in Before next release: bring main's 0.2.0 changes into develop and fix the setup guide's broken install link #282, so this PR doesn't duplicate that larger version/release fix.
• Fixed 8 wrong dincli command names across roles/model-owner.md, manifest.md, and workflows/model-workflow.md (verified each against the current dincli/cli/task.py and dincli/cli/modelownerd/model.py), e.g. registry request-registration → task model-owner register-request, model create-genesis → model create-genesis-model, system get-fees → system get-registry-fee.
• Removed the non-existent sepolia_devnet and non-functional mainnet from the network-option lists in setup.md, cli-reference.md, and roles/clients.md (verified against dincli/config/din_info.json, which only has local/sepolia_op_devnet real entries and literal 0x... placeholders for mainnet).
• getting-started.md: added a note clarifying this guide documents develop's protocol flow (including the aggregator/auditor commit-then-reveal steps, added after the initial devnet deployment) which can be ahead of what's live on sepolia_op_devnet, and pointed readers at dincli task gi show-state 0 to check the real state instead of trusting a hardcoded "GI 2 in progress".

Stale or misleading:

• GOOD_FIRST_ISSUES.md: the DP governance review starter task was listed as open; it was completed in PR docs(dp): governance review of DevNet DP baseline (starter task) #89. Updated the listing to point at the result and the good first issue label instead.
• getting-started.md: softened the "fully verifiable end-to-end" / "cryptographic and economic enforcement" claim to not contradict the page's own later note that reward/slashing economics are still under active development.
• roles/model-owner.md: "DAO Approval" → "DIN-Representative Approval" (DAO governance is deferred to post-mainnet; today's approveModel/approveManifestUpdate calls are onlyOwner, held by the DIN-Representative).
• Naming drift: Infinite Zero → InfiniteZero in getting-started.md and model-workflow.md to match the canonical form used in README.md and everywhere else in the repo; sepolia-op-devnet → sepolia_op_devnet (the real config value) in getting-started.md.
• Replaced the dead Telegram invite link in getting-started.md with the current one (already used correctly in model-workflow.md).
• Skipped the README.md wording item (checklist item 7) — already covered by the open docs: refresh README, add CITATION.cff and impact page #280.
• din-workflow.md and model-workflow.md: dropped "(later DIN-DAO)" after "DIN-Representative" — governance is out of scope for now.
• cli-reference.md and roles/model-owner.md: "DAO administrators"/"the DAO admin" → DIN-Representative, matching the fee-withdrawal calls which are onlyOwner.
• Developer/design/whitepaper-summary.md: the white paper zip was replaced by a PDF upstream; updated the source link.
• roles/model-owner.md: dropped the --manifestCID register-request warning now that dincli: task model-owner register-request --manifestCID fails because the registry contract isn't initialised #295 is fixed (PR fix(dincli): initialize the registry contract on the register-request --manifestCID route #297, develop@e9424af); documented both --manifestpath/--manifestCID routes the way update-manifest-request already does.

Thin or unclear:

• Fleshed out Developer/DEVELOPMENT_SETUP.md: Python 3.12+ requirement, Foundry install, how to run the Python and Solidity test suites (pip install -e ".[test]" + pytest -m "not integration", matching CI), and a link to Documentation/technical/testing/.
• Populated the previously-empty Developer/CODE_STANDARDS.md.
• Developer/CONTRIBUTING.md: a file path was sitting inside a bash code block as if it were a shell command — moved it out as a plain link.
• Fixed the malformed [!NOTE] rendering as raw text inside an unclosed code fence in setup.md.
• Fixed two typos in workflows/model-workflow.md ("manisfest", "Protocolat").
• manifest.md: corrected the false claim that create-genesis-model auto-creates a missing manifest.json — it exits with an error instead; the real recovery path (cache-default-artifacts) only has a configured default_manifest CID for local, not sepolia_op_devnet/mainnet.

Verification

• python3 .github/scripts/check_doc_links.py Documentation Developer — all 573 inline relative links resolve.
• Every renamed/fixed dincli command verified against the actual registered Typer commands in dincli/cli/task.py and dincli/cli/modelownerd/model.py, not just the issue's text.
• Network-options claims verified against dincli/config/din_info.json.
• --manifestCID fix verified against current dincli/cli/task.py (dinregistry_contract now assigned unconditionally) and issue dincli: task model-owner register-request --manifestCID fails because the registry contract isn't initialised #295's closed state.

🤖 Generated with Claude Code

[Santiagocetran]

Thanks, Abidoye. Reviewed c663209 against develop 954fbf8 and #290. Several onboarding instructions still need correction:

1. P2: Explicitly select develop during installation.

The new source-install instructions use a bare git clone, which currently selects main, while the following text promises develop. Please select develop explicitly and explain that editable installation follows the checkout; it doesn’t automatically track upstream updates. Also distinguish this unreleased code from the live DevNet setup, as clarified in #282.

2. P2: Separate the basic Python test command from integration testing.

The basic setup uses pip install -e . and then recommends bare pytest. There is a general dependency note for ML/DP work, but no explicit installation of the test extras for this command.

Once its prerequisites are available, bare pytest also selects the integration harness, whose autouse fixtures compile contracts and manage local chain/IPFS services, including restarting local chain processes in non-isolated mode.

Please install the test extras and use the non-integration selection for the basic workflow, consistent with CI. Link full integration runs separately with their prerequisites and disposable-environment guidance.

3. P2: Qualify the newly advertised registration --manifestCID route.

The example reaches an existing CLI defect: supplying a CID skips registry initialization, then the fee lookup uses that unbound local.

Please document the manifest-file route or flag the limitation pending a separate fix. The manifest-file route avoids this particular defect; I have not verified it end to end. This finding applies to registration, not manifest updates, and does not require a runtime-code fix in this documentation PR.

4. P2: Correct the retained boolean-option syntax.

The renamed registration command still shows --isOpenSource [true/false]. It is a switch: include --isOpenSource for true and omit it for false.

5. P2: Remove the automatic manifest-creation promise.

The manifest note still says genesis creation automatically supplies a missing manifest, but the implementation exits when it is absent. Explain preparation explicitly. Default-artifact caching requires an existing task directory and configured network defaults; the bundled sepolia_op_devnet configuration lacks default_manifest, so caching is not a universal recovery path.

Items 4 and 5 are retained documentation errors in the examples this PR edits, not newly introduced code regressions.

Please reconcile the overlapping changes with #291 before final verification. CI passed for this head/base pair, but its link checks don’t establish that onboarding commands work. This review is based on source inspection and observed CI, not execution of the setup or live-network commands.

[abrahamnash]

Thanks @Abidoyesimze, this covers more of #290 than my #291, so let's go with yours and I'll close #291. On top of @Santiagocetran's review, a few fixes from #291 that aren't in here yet:

• workflows/din-workflow.md:5 and workflows/model-workflow.md:8: drop "(later DIN-DAO)"
• cli-reference.md:3 ("DAO administrators") and roles/model-owner.md:48 ("the DAO admin"): these are the DIN-Representative
• Developer/design/whitepaper-summary.md:3: the white paper zip was replaced by a PDF, so the link should be https://github.com/InfiniteZeroFoundation/White-Paper/blob/main/Decentralized%20Intelligence%20Network%20%28DIN%29.pdf

The --manifestCID defect is now tracked in #.

[Abidoyesimze]

Pushed 31bb970 addressing both reviews:

@Santiagocetran:

1. setup.md now explicitly git checkout develop after cloning (a bare clone lands on main), and clarifies the editable install doesn't auto-track upstream — git pull in the same clone picks up new commits without reinstalling. Also reframed the note to make clear this is unreleased develop code that can be ahead of the live sepolia_op_devnet deployment, not a release.
2. DEVELOPMENT_SETUP.md now installs pip install -e ".[test]" and runs pytest -m "not integration" for the basic workflow, matching CI's Python job, with a pointer to the dincli testing guide for the full integration suite.
3. Confirmed the --manifestCID defect by reading register_request in dincli/cli/task.py — dinregistry_contract is only assigned inside the if not manifestCID: branch, so passing --manifestCID directly hits an UnboundLocalError at the fee lookup before any tx. Filed as dincli: task model-owner register-request --manifestCID fails because the registry contract isn't initialised #295 and removed --manifestCID from the register-request example in roles/model-owner.md in favor of --manifestpath, with a warning linking the issue. (update-manifest-request doesn't have this bug — it initializes the registry contract unconditionally — so I left that one's --manifestCID option alone.)
4. Fixed --isOpenSource [true/false] → [--isOpenSource] in model-workflow.md — it's a flag, not a value option.
5. Verified in dincli/cli/modelownerd/model.py: create-genesis-model exits with an error if manifest.json is missing, it does not auto-create it. The actual recovery path, cache-default-artifacts, pulls from a default_manifest CID in din_info.json — but only local has one configured; sepolia_op_devnet/mainnet don't. Rewrote the note in manifest.md to say so.

@abrahamnash: dropped "(later DIN-DAO)" from din-workflow.md and model-workflow.md, fixed cli-reference.md's "DAO administrators" and model-owner.md's "DAO admin" (fee withdrawal) to DIN-Representative, and updated the whitepaper-summary.md source link to the PDF.

check_doc_links.py still passes (573 links, all resolve).

[umeradl]

Closing keyword: please change Closes #290 to Part of #290.

We're about to make develop the default branch, so from now on a Closes/Fixes/Resolves line in a PR body or commit message closes the issue automatically when the PR merges (Developer/MAINTAINING.md No. 4.3).

This PR deliberately leaves two of issue No. 290's checklist items for later: item 1 (packaged install, deferred to issue No. 282) and item 7 (README wording, deferred to issue No. 280). Merging it with Closes would close No. 290 while those two items are still open. Please switch the PR body (and any commit message that has it) to Part of #290. Issue No. 290 then gets closed once the remaining items land, or once its body is updated to move them out of scope.

[umeradl]

Heads-up on Documentation/public/roles/model-owner.md: the --manifestCID crash is fixed. PR No. 297 merged into develop as e9424af, and issue No. 295 is closed. That makes the > [!WARNING] block under register-request ("Use --manifestpath, not --manifestCID … currently crashes with an UnboundLocalError") stale.

Before this merges, could you:

1. Drop that warning block.
2. Document both routes in the register-request usage, the way update-manifest-request already shows them:

   dincli task model-owner register-request \
     --taskCoordinator <coordinator_address> \
     --taskAuditor <auditor_address> \
     [--manifestpath <path_to_manifest.json> | --manifestCID <manifest_cid>] \
     [--isOpenSource]

   and a line noting that --manifestCID skips the IPFS upload and uses an already-pinned manifest.

Please check Documentation/public/cli-reference.md and workflows/model-workflow.md in this PR for the same warning too.

[robertocarlous]

Reviewed against develop in an isolated worktree (pr-294-review on top of 31bb9701, the PR head). Peer check: OK (Abidoyesimze is the author; operator is not).

CI on 31bb9701: All checks green ✅ — docs link-check (573 links resolved), Python unit tests pass.

The PR's own work is two commits: c6632092 (main fixes) and 31bb9701 (review feedback, getting-started.md).

---

Claimed — broken install path in setup.md fixed. Verified: old wheel/git-install instructions replaced with git clone + pip install -e . (and DEVELOPMENT_SETUP.md separately adds pip install -e ".[test]" with the test extra). The [test] extra (pytest>=8.0, torch>=2.6) exists in pyproject.toml [project.optional-dependencies].

Claimed — 8 wrong command names corrected. Verified each against source:

• register-request → dincli/cli/task.py L185 ✓
• update-manifest-request → dincli/cli/task.py L293 ✓
• show-registration-request → dincli/cli/task.py L371 ✓
• create-genesis-model → dincli/cli/model.py L46 ✓
• submit-genesis-model → dincli/cli/model.py L162 ✓
• get-registry-fee → dincli/cli/system.py L1620 ✓
• update-manifest-request (in manifest.md) ✓
• register-request (in model-workflow.md) ✓

Claimed — network options corrected to [local | sepolia_op_devnet] only. Verified: mainnet key exists in din_info.json but carries 0x... placeholder addresses — not functional. Removing it from participant-facing docs is correct. All changed files consistently use the two-option form.

Claimed — sepolia-op-devnet → sepolia_op_devnet corrected. Verified: din_info.json uses underscored key; hyphenated form would silently fail at network resolution.

Claimed — naming drift fixed (Infinite Zero → InfiniteZero, (later DIN-DAO) removed, DAO → DIN-Representative). Verified in getting-started.md, model-owner.md, din-workflow.md, and cli-reference.md. DIN-Representative is the current canonical term throughout Developer/MAINTAINING.md.

Claimed — CONTRIBUTING.md broken raw path fixed. Verified: old /Developer/DEVELOPMENT_SETUP.md (non-rendering raw path with leading slash) replaced with [DEVELOPMENT_SETUP.md](DEVELOPMENT_SETUP.md) (proper relative markdown link).

Claimed — DEVELOPMENT_SETUP.md expanded with requirements, Foundry setup, and test commands. Verified: Requirements block lists Python >=3.12, Foundry, Node.js; pip install -e ".[test]" matches pyproject.toml; -m "not integration" matches the integration marker registered at pyproject.toml L50 ("marks tests that require a live Hardhat node, IPFS daemon, and Docker"); npm ci before forge test rationale matches CLAUDE.md exactly.

Claimed — GOOD_FIRST_ISSUES.md Task 0 marked completed. Verified: heading updated to "✅ Completed"; PR link to No. 89 and audit doc link to Documentation/technical/audits/dp-mechanism-review.md added; good first issue label search link added for incoming contributors. Audit file exists in the worktree ✓.

Claimed — whitepaper-summary.md URL corrected. Verified: .pdf.zip path replaced with .pdf (URL-encoded parens %28DIN%29), removing the broken zip extension from the direct PDF link.

Claimed — stale hardcoded GI state removed from getting-started.md. Verified: hardcoded "GI: 1" replaced with dincli task gi show-state 0 note, which is the correct command (exists at task.py ✓).

Claimed — dead Telegram link replaced. Verified: placeholder link removed, GitHub Discussions link substituted.

Claimed — "fully verifiable" claim softened. Verified: qualified language used, avoiding an unsubstantiated protocol claim in public-facing docs.

573 links all resolve. CI docs link-check confirms ✓.

---

No findings. Merge-ready; branch needs update-branch before merge (BEHIND develop, no conflict). No foundry/src/** touched; no second sign-off required.

[robertocarlous]

Head at review: 31bb9701
Merge base (upstream develop): behind but clean — no conflict (merge-tree exit 0)

---

Documentation/public/setup.md

Key	Value
Change	+21/-15 lines: broken wheel/git+https install replaced with git clone + pip install -e .; [!NOTE] code fence fixed; network options updated to [local | sepolia_op_devnet]
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Documentation/public/workflows/model-workflow.md

Key	Value
Change	+7/-9 lines: create-genesis → create-genesis-model, submit-genesis → submit-genesis-model, register → register-request, manisfest/Protocolat typos, Infinite Zero → InfiniteZero, (later DIN-DAO) removed
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Documentation/public/roles/model-owner.md

Key	Value
Change	+16/-12 lines: 8 wrong command names corrected, DAO → DIN-Representative, get-fees → get-registry-fee, [!WARNING] about --manifestCID crash added
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Documentation/public/getting-started.md

Key	Value
Change	+7/-6 lines: Infinite Zero → InfiniteZero, sepolia-op-devnet → sepolia_op_devnet, hardcoded GI state replaced with dincli task gi show-state 0, dead Telegram link replaced, "fully verifiable" softened
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Documentation/public/manifest.md

Key	Value
Change	+3/-3 lines: create-genesis → create-genesis-model, manifest creation note corrected, update-manifest → update-manifest-request
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Documentation/public/cli-reference.md

Key	Value
Change	+2/-4 lines: network options corrected; DAO → DIN-Representative
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Documentation/public/roles/clients.md

Key	Value
Change	+1/-3 lines: network options corrected
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Documentation/public/workflows/din-workflow.md

Key	Value
Change	+1/-1 lines: DIN-Representative (later DIN-DAO) → DIN-Representative
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Developer/DEVELOPMENT_SETUP.md

Key	Value
Change	+48/-3 lines: Requirements block added (Python >=3.12, Foundry, Node.js); pip install -e ".[test]" with rationale; pytest -m "not integration" command; Foundry setup section; testing reference section
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Developer/CODE_STANDARDS.md

Key	Value
Change	+47/-0 lines (was empty): Python, Solidity, and general standards documented; consistent with CLAUDE.md and foundry/foundry.toml; cross-references CONTRIBUTING.md contract-size budget section
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Developer/CONTRIBUTING.md

Key	Value
Change	+2/-4 lines: broken raw path /Developer/DEVELOPMENT_SETUP.md replaced with proper relative markdown link
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Developer/GOOD_FIRST_ISSUES.md

Key	Value
Change	+4/-7 lines: Task 0 marked completed; PR No. 89 link and dp-mechanism-review.md audit link added; good first issue label search link for new contributors
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

Developer/design/whitepaper-summary.md

Key	Value
Change	+1/-1 lines: whitepaper URL fixed (.pdf.zip → .pdf with URL-encoded parentheses)
Pending proposal	None
Recommended merge proposal	Merge as-is
Actual merge proposal	Soon

[robertocarlous]

Docs-only fix — all 8 wrong command names, broken install path, network options, DAO→DIN-Representative naming drift, and stale status all verified against source at 31bb970

[Abidoyesimze]

Pushed 5a1c00b addressing both outstanding items:

1. PR body switched from Closes #290 to Part of #290 — this PR deliberately leaves items 1 and 7 of docs: fix broken install path, wrong commands and stale status in participant guides #290's checklist to Before next release: bring main's 0.2.0 changes into develop and fix the setup guide's broken install link #282 and docs: refresh README, add CITATION.cff and impact page #280, so docs: fix broken install path, wrong commands and stale status in participant guides #290 shouldn't auto-close on merge.
2. Dropped the stale --manifestCID warning in roles/model-owner.md now that dincli: task model-owner register-request --manifestCID fails because the registry contract isn't initialised #295 is fixed (confirmed against current dincli/cli/task.py — dinregistry_contract is assigned unconditionally now, and dincli: task model-owner register-request --manifestCID fails because the registry contract isn't initialised #295 is closed). register-request's usage block now documents both --manifestpath/--manifestCID routes the way update-manifest-request already does, with a one-liner on what --manifestCID skips.

Checked cli-reference.md and workflows/model-workflow.md for the same warning as requested — neither had one, so no change needed there.

check_doc_links.py still passes (573 links, all resolve).