Repository navigation
feat(indexer): add opt-in raw-string substring ranking - #272
Conversation
Related tracker: #255. Preserve the default lexical method, substring and context contracts; publish the unchanged one-run synthetic contract evidence and separate current-main integration checks. New material source author: configured gpt-6-astra / xhigh agent. This does not certify historical PR authorship or general retrieval efficacy. Signed-off-by: Codex <codex@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Dong1017
left a comment
There was a problem hiding this comment.
LGTM for the opt-in raw-string substring contract at 95a35192. The mode removes serialization-created phantom matches while preserving substring matching and the unchanged default path.
- Frozen evidence: 14 scalar cases and 2 ranking fixtures pass; 5 phantom contributions removed, all 26 expected positives retained. These are synthetic contract checks, not general retrieval-accuracy evidence.
- 21 compatibility requests preserve behavior. Current Ready CI and author declaration pass; native review has no findings, and no unresolved review threads remain.
- The new main guidance change has no file or reader/ranker/corpus intersection. The broader Indexer tracker remains open, with no default promotion.
Evidence and integration limits
Head: 95a3519. Frozen candidate: 728984c524cf696d063ff7ef0688ae126c8546a6. Local verification: 2707 passed, 12 skipped; current-base patch integration: 108 passed, 2 skipped; Ruff passed. Ready CI, declaration, native source comment 6520834588. Earlier opened-event run was superseded by successful Ready CI. CI tested base 436c950; subsequent main db4e8a1 was inspected for integration intersections, not a fresh scored-study run. Frozen evidence was retained unchanged.
Summary
Related tracker: #255; its broader requirements remain open.
relevance_method="weighted-raw-string-v1"/--relevance-method weighted-raw-string-v1so actual string newlines/tabs do not become phantom lexical matches from JSON escapes.Evidence, checks and limits
The one frozen synthetic contract study passes all 14 scalar cases and 2 ordering fixtures: five phantom field-token contributions removed; 15 original-string and 11 expected nonstring-JSON positives retained; 21 compatibility requests preserved. Actual newline+tab title: score 8→0; literal backslash-letter title: 8→8. This is not general retrieval accuracy, efficacy or latency evidence.
Frozen baseline
1052925f, candidate728984c5; archive and original Git bundle preserve those identities. Publication integrates onto436c950cwithout rerunning the study. Independent source, retained-output and publication-wrapper reviews found no blocker.Evidence and provenance distinguish this new configured author from historical protocol/fixture/reviewer records. No historical PR authorship is certified.