Repository navigation
perf(indexer): avoid redundant view sizing after item limit - #270
Conversation
Preserve full resource validation, subclass error behavior and bounded paired evidence for #255. Signed-off-by: Codex <codex@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Retain both independent frozen studies and reconcile the additive inventory counts. Preserve the exact-Bundle fast path together with the opt-in raw-string selector. Agent-assisted-by: Codex / gpt-6-astra [effort=xhigh] (integrator) Signed-off-by: Codex <codex@openai.com>
Dong1017
left a comment
There was a problem hiding this comment.
No additional blocking source defect found in faef926; merge readiness is still blocked by the current author-declaration check.
- The exact-
Bundlefast path skips only redundant sizing after count saturation. Reads/resource validation, filtering/ranking, byte-budget handling and custom-subclass serialization remain on their existing paths. I also checked its boundary with the newly merged opt-in raw-string selector. - All four Ready jobs pass. The current policy result is noncompliant, with “Missing, invalid or stale knowledge author declaration”; it is not a source-test failure or an infrastructure outage. The existing author, @Dong1017, needs a valid declaration applicable to this head.
- The retained study reports a 9.434% paired latency reduction on its frozen earlier baseline. Those measurements were not repeated on current main; accuracy, broad tail safety and the overall #255 goals remain unaccepted. The reported search p95 uncertainty remains explicit.
- This is a source/status review, not LGTM or formal approval. I used source and existing hosted evidence; I did not run tests, the benchmark, archive verification, models or devices.
Evidence and exact versions
- Reviewed head:
faef9267b3e2f99bb1f385ecfa5b095796585626. - Assessed API base / observed main:
95e169fb2d4528f6a94492df394c69d9b7be8139; raw-string delivery head:95a35192668d155e30c5b1d97146a6a5ddc84d96. - Source: collect/select and intake, Bundle validation/view, added serialization tests, campaign protocol/runner and retained candidate patch.
- Ready: Python 3.10/3.11 full-check and installed-package jobs succeed. Current policy: status
57664049583, evaluated head matches above, executionok, admissionnoncompliant. The automatic Skill Eval path filters do not select this runtime/evidence-only diff; no comparison pass is inferred. - Frozen study, raw evidence and limits: measured baseline
f93df0548a26714f6514337a8525c7c14108acad, candidate9f7862a9f8619dd68ac59f12736f6b50da10d9e8. The five-line runtime delta matches the retained candidate patch. Reported arithmetic/output audit is retained evidence, not a new benchmark or independent raw-archive recomputation in this review. - COMMENTED is appropriate here: the authenticated GitHub account is also the PR author, and the declaration blocker remains.
Dong1017
left a comment
There was a problem hiding this comment.
LGTM for the bounded efficiency slice at faef9267. The prerequisite in the earlier source review is now satisfied: the current-head owner-confirmed author declaration passes policy CI.
- All four Ready checks pass. Native and independent integration reviews found no additional blocker.
- Additive inventory conflicts are reconciled; the original five-line optimization and both frozen evidence sets remain intact. Default and opt-in raw-string behavior were checked across the integration boundary.
- The 9.434% paired reduction belongs to the frozen historical study, not a fresh benchmark of current main. General accuracy and broader tracker acceptance remain outstanding.
Traceability
Inspected head faef926; main 95e169f; tree 23ceb5431b51788cb4582edcff43a111b0122f50. Reconciles the 2026-10-30 12:20:45 COMMENTED review and native comment 6518777294. Integration verification includes 140 focused tests, 13 exact-output comparisons and preserved frozen files. The initial local whole-suite attempt had a precommit HEAD/index mismatch and three subprocess timeouts; affected suites passed isolated reruns and final hosted whole suites passed. No new model, hardware or scored-study run.
Summary
Evidence
Baseline f93df05; measured candidate 9f7862a9f8619dd68ac59f12736f6b50da10d9e8. One frozen 120-pair study, no retries/pooling. See result table and limits.
Untouched search CLI p95 point change +8.99% passes the prespecified 20% guard, but its confidence interval remains wide (−42.02%…+32.85%). No broad tail-safety, production SLO, model/hardware efficacy or accuracy gain is claimed.
Verification
Related to #255 (tracker remains open).
Current-main integration verification
95e169fb2d4528f6a94492df394c69d9b7be8139in headfaef9267b3e2f99bb1f385ecfa5b095796585626. Reconciled the two additive evidence-inventory conflicts, retaining both frozen studies; the inventory now covers 16 bundles and 336 checked hashes.Knowledge authorship declaration
The owner confirmed the actual authoring configuration as
gpt-6-astra/xhigh; the same confirmed configuration covers the integration work. This is an owner-confirmed provenance declaration, not independent backend attestation.