🔀 :: (#297) 티켓 오픈 작업 - #301
Merged
Merged
Conversation
Closed
- composition은 unstable한 클래스이므로 람다를 통한 지연-read를 사용해 stable 하도록 처리 - HomeSideEffect.ShowOpenAnimation에 capsuleId 추가
Member
|
해당 부분 맞춰서 수정사항 진행 완료됬나요? |
Cjsghkd
approved these changes
Sep 7, 2026
Member
|
근데 이거 로컬 저장 값 로그아웃하면 지워주는게 좋을 것 같긴합니다 |
Collaborator
Author
|
로그아웃 시 오픈된 캡슐 id를 지우면 캡슐 오픈 애니메이션이 중복 노출되는 경우가 생길 수도 있어 보입니다 |
Cjsghkd
requested changes
Sep 7, 2026
Cjsghkd
left a comment
Member
There was a problem hiding this comment.
오픈 티켓 애니메이션 관련 로직 통일 이후 머지 예정
# Conflicts: # app/build.gradle.kts # app/src/main/java/com/idiotfrogs/memoryseal/MainActivity.kt # app/src/main/java/com/idiotfrogs/memoryseal/MainViewModel.kt # core/navigation/src/main/java/com/idiotfrogs/navigation/Routes.kt # feature/profile/src/main/java/com/idiotfrogs/profile/profile/ProfileViewModel.kt # settings.gradle.kts
Cjsghkd
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 개요
📃 작업 내용
💻 구현 화면
2168.mp4
🎸 기타