count_extreme is no longer zero - #11
Merged
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sarthakpati
reviewed
Aug 1, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a statistical bug where permutation tests could produce p-values of exactly zero, which implies absolute certainty despite finite sampling. The fix implements a conservative adjustment by setting count_extreme to 1 when it would otherwise be zero.
- Adds a check to prevent zero p-values in permutation testing
- Implements conservative p-value estimation following statistical best practices
- Adjusts both
count_extremeandn_iterationsto maintain proper calculation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed the bug creating a zero p-value occurence. count_extreme variable is now set to 1 if its value is zero. Dependent on #8 .