Rename the four-argument add! to scaleadd! - #239
Merged
Merged
Conversation
`add!(dest, src)` adds while the four-argument form computes `β * dest + α * src`, so the scaled operation gets its own name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 83.40% 83.21% -0.20%
==========================================
Files 29 29
Lines 946 947 +1
==========================================
- Hits 789 788 -1
- Misses 157 159 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 2, 2026
The extension overloads the four-argument method for `AbstractTensorMap` and calls it from `copyto!`, so it follows the rename. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mtfishman
added a commit
to ITensor/GradedArrays.jl
that referenced
this pull request
Oct 3, 2026
## Summary Follows the rename of TensorAlgebra's four-argument `add!` to `scaleadd!` (ITensor/TensorAlgebra.jl#239). Call sites only, no change to what GradedArrays itself exposes. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
mtfishman
added a commit
to ITensor/ITensorBase.jl
that referenced
this pull request
Oct 3, 2026
## Summary Follows the rename of TensorAlgebra's four-argument `add!` to `scaleadd!` (ITensor/TensorAlgebra.jl#239). The `VectorInterface` methods keep the `add!` name, since that is VectorInterface's own interface rather than TensorAlgebra's. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the four-argument
add!(dest, src, α, β)toscaleadd!, leavingadd!with only its two-argument meaning. One name for two operations was easy to misread, sinceadd!(dest, src)adds while the four-argument form computesβ * dest + α * src.