Require subtypes to define encoded_graph - #194
Merged
Merged
Conversation
The developer page said a type without an integer graph only needs `encoded_vertex` and `decoded_vertex`. A type built that way recurses on every topology call, because `EncodedGraphView` answers those by asking the named graph back. The page now says what such a type defines and describes the `f_namedgraph` hooks. The `PartitionedGraphs` docstring put `add_subquotientvertex!` under `Graphs`, where it does not exist.
Makes `encoded_graph` a required method, with `EncodedGraphView` an explicit opt-in for types that compute their own topology. Its silent default was the view, which asks the named graph back for its topology, so a subtype defining only the vertex translation recursed. The view also gains `has_edge(g, s, d)`, `copy`, and `blockdiag`, which Graphs.jl and the fallbacks call on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
encoded_graphrequired, withEncodedGraphViewan explicit opt-in for types that compute their own topology. Its silent default was the view, which asks the named graph back for its topology, so a subtype defining only the vertex translation recursed. The view also gainshas_edge(g, s, d),copy, andblockdiag, andeccentricitiesis documented and exported.