Make all_edges public and give it a real iterator - #192
Merged
Merged
Conversation
Gives `all_edges` on an undirected graph a lazy iterator instead of a flattened lazy `map`, so its element type and length survive. The flatten inferred `eltype` as `Any` and threw on `length`, which broke callers dispatching on the element type.
`all_edges` never needed a generic graph, so it moves to `NamedGraphs` proper alongside the other named-graph functions, and both edge iterators tighten to named types. Two dependent packages call it, so it is documented and exported rather than reached for as an internal.
mtfishman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
all_edgesreturned a flattened lazymap, so its element type wasAnyand its length threw, and it was undocumented and unexported despite two dependent packages calling it. It now returns a lazy iterator keeping both, is narrowed to named graphs, and is exported. Also strengthens theedge_subgraphtest from #175.