Remove the GraphsExtensions submodule - #190
Merged
Merged
Conversation
Moves the contents of the `GraphsExtensions` submodule into `NamedGraphs` directly, so downstream stops naming it. The submodule encapsulated nothing: all twelve of its exports were already re-exported, and Julia does not enforce submodule privacy.
The default is never populated automatically, but setting it with `set_partitioning_backend!` works, so the comment saying the state was dead in practice was wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the contents of the
GraphsExtensionssubmodule intoNamedGraphsdirectly, so downstream stops naming it. The submodule encapsulated nothing: all twelve of its exports were already re-exported, and Julia does not enforce submodule privacy.