Improve expect implementation and tests - #383
Merged
Merged
Conversation
…a dictionary when no vertices passed and a vector when a vector of vertices is passed.
Member
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve implementation and tests of expect to ensure return value is a dictionary when no vertices passed and a vector when a vector of vertices is passed.
Call -> Returns
Two notes on the whole-network case:
The type is OrderedDictionary, not Dictionaries.Dictionary. vertices(ψ) is a
NamedGraphs.OrderedDictionaries.OrderedIndices, so map over it yields the matching OrderedDictionary — an
AbstractDictionary keyed by vertex, iterating in vertices(ψ) order.
Element types stay concrete — Float64, not Any. Going through Indices/Dictionary directly widens to Any because
Dictionaries.jl sizes the output by inference and expect's contract(...)[] doesn't infer; OrderedDictionary's map
doesn't have that problem.