Fix broken mermaid diagrams, drop SparseArraysBase from the nav - #59
Merged
Merged
Conversation
The ecosystem overview diagram stopped rendering: mermaid 11.17.0 breaks when a global AMD `define` is present, which Documenter's require.js provides (mermaid-js/mermaid#8095). Render the diagrams from a pinned version until that is fixed. Also drops `SparseArraysBase` from the nav for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ecosystem overview diagram stopped rendering: mermaid 11.17.0 breaks when a global AMD
defineis present, which Documenter's require.js provides (mermaid-js/mermaid#8095). Render the diagrams from a pinned version until that is fixed. Also dropsSparseArraysBasefrom the nav for now.