Repository navigation
Remove the lazy and symbolic ITensor layer, and rename dim to findname - #270
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 78.13% 82.46% +4.32%
==========================================
Files 30 21 -9
Lines 1834 1471 -363
==========================================
- Hits 1433 1213 -220
+ Misses 401 258 -143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
`dim(a, n)` returns the position of the dimension named `n`, but the name says size everywhere else in the ecosystem. `find*` in Base returns a location and is non-strict, which is already how this behaves for a name that is absent. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mtfishman
changed the title
dim to findname
mtfishman
changed the title
dim to findnamedim to findname
mtfishman
marked this pull request as ready for review
October 6, 2026 00:46
mtfishman
added a commit
to ITensor/ITensorNetworksNext.jl
that referenced
this pull request
Oct 7, 2026
…actionTree` (#203) ## Summary Contraction orders become an explicit `ContractionTree` over the network's keys, and `prod_tensors` is the single way to contract, taking either a tree or an algorithm that finds one. This removes `contract_network`. Order finding moves here from ITensorBase (ITensor/ITensorBase.jl#270), its only consumer, so the lazy layer there could be removed. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
LazyNamedTensor,SymbolicNamedTensorand the contraction-order finding built on them, along with five dependencies. Order finding moves up to ITensorNetworksNext (ITensor/ITensorNetworksNext.jl#203), its only consumer. Also renamesdimtofindname, since it returns a position rather than a size.