Repository navigation
Named-tensor contraction with a contraction algorithm and operand conjugation - #267
Merged
Merged
Conversation
…mul!` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Operator and lazy tensors keep their wrappers through `*`; with the `AbstractNamedTensor` method, `contract` returned a plain `NamedTensor`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 77.69% 78.00% +0.31%
==========================================
Files 30 30
Lines 1820 1823 +3
==========================================
+ Hits 1414 1422 +8
+ Misses 406 401 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtfishman
reviewed
Sep 30, 2026
Named-tensor contraction uses matrix-operation names: `mul!` (3- and 5-argument, with `alg`) and the new `mulopadd!`. The `TensorAlgebra.contract`, `contract!` and `contractopadd!` methods for named tensors are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mtfishman
reviewed
Oct 2, 2026
…padd!`. Co-authored-by: Matthew Fishman <mtfishman@users.noreply.github.com>
mtfishman
enabled auto-merge (squash)
October 2, 2026 17:22
Member
|
Thanks! |
The public declaration added mulopadd!, so the expected list needs it too. Only Julia 1.11 and newer compares public names, which is why the lts jobs passed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mtfishman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Named-tensor contraction can now select a TensorAlgebra contraction algorithm and conjugate an operand without copying it.
mul!passes keyword arguments such asalgthrough to TensorAlgebra, and the newmulopadd!accumulates a scaled product with either operand conjugated.