Improve trt discover and NN interpolation bugfix - #1
Open
tcollins-hub wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grid_sample_3d_nearest_kernel) where the per-channel input/output pointers were never advanced across the channel loop. ForC > 1, every channel read from input channel 0, and only output channel 0 was ever written — all other output channels were left uninitialized.CMakeLists.txt(see21cc043).Testing
testGridSample3dNearestMultiChannelintest.cpp) covering the multi-channel nearest-neighbor bug specifically:(c, d, h, w)voxel and an identityalign_corners=truegrid, so each output voxel must exactly equal the input voxel at the same coordinates.-1) before running the kernel, so any element the kernel fails to write (as happened for channels > 0 before the fix) is caught rather than masked by leftover memory.cmake -B buildconfigure and build from the committed sources (only pre-existing TensorRT deprecation warnings, no errors), thenctest --output-on-failure— 100% tests passing, including the existingtestGridSample3dFloat32sanity test against reference data intest/data/.