Support new versioning scheme#137
Open
pleasant-menlo wants to merge 6 commits into
Open
Conversation
…y file. Update GLOWS L3b to handle new major.minor version format.
…s minor version only for compatibility
# Conflicts: # tests/periodically_run_tests.json
Collaborator
|
@bryan-harter @tech3371 @vineetbansal , can one of you take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Implemented handling of major version in IMAP L3 processing including the jobs that manage their own version numbers (cron jobs for GLOWS and maps).
The dependency JSON can now contain additional information about the requested version:
We currently assume that version information will only be provided for a single descriptor, because our existing dependency configuration only specifies a single output for each job. This may need to be revisited if the dependency system later expects several outputs for a single L3 job.
The parallel change to imap_processing was made in IMAP-Science-Operations-Center/imap_processing#3313.
See IMAP-Science-Operations-Center/sds-data-manager#1397 for the top-level issue.
Closes #118.
File changes
Version objects are now created from the dependency JSON when they contain version numbers and otherwise fall back to creating version objects from the command line arguments.
Testing
Invoking any job from the command line using a dependency JSON that includes the version numbers should result in an output with the corresponding major and minor version numbers.