Fix GitHub Pages deploy job OIDC permissions - #197
Open
ptrbortolotti with Copilot wants to merge 3 commits into
Open
Fix GitHub Pages deploy job OIDC permissions#197ptrbortolotti with Copilot wants to merge 3 commits into
ptrbortolotti with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: ptrbortolotti <20641647+ptrbortolotti@users.noreply.github.com>
Co-authored-by: ptrbortolotti <20641647+ptrbortolotti@users.noreply.github.com>
Co-authored-by: ptrbortolotti <20641647+ptrbortolotti@users.noreply.github.com>
Copilot
AI
changed the title
Fix GitHub Pages deploy job permissions
Fix GitHub Pages deploy job OIDC permissions
Aug 6, 2026
Copilot created this pull request from a session on behalf of
ptrbortolotti
August 6, 2026 17:57
View session
ptrbortolotti
marked this pull request as ready for review
August 6, 2026 18:02
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates repository hygiene and GitHub Pages deployment permissions.
Changes:
- Ignore a generated/derived
windIO/version.pyfile. - Add explicit
permissionsto the GitHub Pages deployment job.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .gitignore | Adds windIO/version.py to ignored files list. |
| .github/workflows/gh-pages.yaml | Grants contents/pages/id-token permissions needed for Pages deployment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
The docs workflow change looks good to me. On ignoring version.py, the explanation makes sense, but I'm not familiar with the setuptools-scm workflow. @fzahle may know more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-pagesworkflow was uploading the Pages artifact successfully, then failing indeploybecauseactions/deploy-pages@v4could not obtain an OIDC token. This change scopes the required Pages/OIDC permissions onto thedeployjob so deployment can complete reliably.Root cause
deploy-pagesrequiresid-token: writein the job that performs the deployment.Workflow changes
deployin.github/workflows/gh-pages.yaml:contents: readpages: writeid-token: writeRepository hygiene
windIO/version.py, which is generated bysetuptools-scm, to avoid committing local build artifacts unrelated to the workflow fix.Relevant change