Repository navigation
Conversation
HeatConduction2D and 3D called their volume target `volume`. Every other volume-constrained problem calls it `volfrac`, so rename it here too. - Rename the condition, the constraint argument, the config keys and the initialize_design keyword from volume to volfrac. - Point at heat_conduction_2d_v1 and heat_conduction_3d_v1. These are clerical copies of v0 with the column renamed. Nothing was recomputed. The container templates read their inputs by position, so they need no change. BREAKING CHANGE: callers pass volfrac instead of volume, in the constructor config, in simulate/optimize configs, and to initialize_design. Refs #256 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #280. Merge #280 first, and this PR then retargets to
main.Why
After #280, every volume-constrained problem calls its target
volfracexcept HeatConduction2D and 3D, which call itvolume. This renames it, so one name means the same thing across the benchmark.What changes
initialize_designkeyword change fromvolumetovolfracin both problems. The constraint has to follow, because it receives its inputs by parameter name.heat_conduction_2d_v1andheat_conduction_3d_v1. They are copies of v0 with one column renamed. Nothing was recomputed. Every other column was checked against the source and is identical, with the same row order.The problem versions stay at 0, as in #280.
Breaking
Callers pass
volfracinstead ofvolume. That applies to the constructor config, tosimulateandoptimizeconfigs, and toinitialize_design.An unrecognized config key is ignored, not rejected. So a caller that still passes
volumein asimulateconfig silently gets the default target. Passing it to the constructor fails loudly.Checks
Pre-commit passes. A design at the default target gives no constraint violation, and one 0.05 above it gives exactly one. The condition order is unchanged, with
volfracfirst.🤖 Generated with Claude Code