Repository navigation
fix panic when netlink subscription terminates - #133
Merged
Merged
Conversation
Signed-off-by: Tamas-Biro1 <60390128+Tamas-Biro1@users.noreply.github.com>
Tamas-Biro1
marked this pull request as ready for review
October 10, 2026 11:27
tamassoos3
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the #130
THe problem: static route operator could crash with
panic: panic called with nil argument. The reason is that Netlink closes the route update channel on any receive error (e.g.ENOBUFS), soRouteManager.Run()then returnednil, andmain.gocalledpanic(nil)with it.In this PR:
RouteManager.Run()now subscribes again when Netlink closes the update channel, so the operator keeps running instead of crashingRun()returnsnilonly whenstopChanis closed, and returns a wrapped error if the subscription failsmain.gono longer callspanic(nil):route manager stopped unexpectedlyif it returnednilCRD not found: staticroutes.static-route.ibm.com