Repository navigation
Conversation
Tamas-Biro1
reviewed
Oct 10, 2026
Tamas-Biro1
reviewed
Oct 10, 2026
Tamas-Biro1
requested changes
Oct 10, 2026
Tamas-Biro1
left a comment
Tamas-Biro1
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution for Static Route operator!
I added some comments and suggestions, also i'm open for further discussion on this issue. Thanks!
FilatovM
force-pushed
the
fix/delete-stale-node-statuses
branch
from
October 12, 2026 12:49
2a2505d to
97ac59f
Compare
Signed-off-by: Mikhail Filatov <misha.filat@gmail.com>
FilatovM
force-pushed
the
fix/delete-stale-node-statuses
branch
from
October 12, 2026 12:50
97ac59f to
c6aad97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for raised issue - #129
When a Kubernetes node disappears unexpectedly, its corresponding entry can remain in StaticRoute.Status.NodeStatus indefinitely. This can leave outdated status information and interfere with the cleanup of StaticRoute resources.
Changes:
Remove stale node statuses: Periodically compare StaticRoute.Status.NodeStatus entries with existing Kubernetes nodes and remove entries for nodes that no longer exist.
Support hostname matching: Match node statuses against both Kubernetes node names and the kubernetes.io/hostname label.
Reconcile periodically: Recheck resources every minute to detect nodes that disappear without the operator having an opportunity to clean up their status entries.
Improve deletion handling: Allow finalizer cleanup to proceed when a deleting StaticRoute has no remaining node statuses.
Handle errors: Propagate failures when listing Kubernetes nodes or updating the StaticRoute status.
Add test coverage: Update controller mocks and tests to cover stale status cleanup and the associated reconciliation behavior.