Repository navigation
fix(governance): reject mismatched proposal target/function/arg arrays - #1756
Merged
Gbangbolaoluwagbemiga merged 2 commits intoSep 30, 2026
Merged
Gbangbolaoluwagbemiga merged 2 commits into
Gbangbolaoluwagbemiga merged 2 commits into
Conversation
Validate that targets, functions, and args have equal length in propose, queue, and execute, returning Error::MismatchedProposalArrays instead of risking an out-of-bounds trap.
|
@libby-coder is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@libby-coder Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Gbangbolaoluwagbemiga
merged commit Sep 30, 2026
8cdd388
into
HyperSafeD:main
35 of 50 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1640
Closes #1365
Closes #1639
Closes #1357
Summary
Prevents out-of-bounds panics when a proposal's
targets,functions, andargsvectors have different lengths (#1640).Error::MismatchedProposalArrays(= 10) to the governance contract's error enum.validate_proposal_arrayshelper that checks all three vectors have the same length.propose, so bad proposals are rejected up front.queueandexecutebefore the loop over proposal actions, so proposals that are already stored are covered too.proposal_actionnow returnsMismatchedProposalArraysinstead of the genericInvalidStateif an index is missing.Files changed
contracts/governance/src/lib.rs